Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop treating namedtuple as an object when using simplejson #1297

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

Hardtack
Copy link
Contributor

@Hardtack Hardtack commented Feb 22, 2021

By default, simplejson converts namedtuple to JSON object but json converts that to JSON array.

This causes unpredictable serialization depends on installation of simplejson. So I added an option for disabling simplejson specific feature.

@thedrow
Copy link
Member

thedrow commented Feb 28, 2021

Why would anyone still use simplejson?

Copy link
Member

@matusvalo matusvalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kombu prefers simplejson when installed. So I think we should fix issues coming from it. If using simplejson is not having benefits we can drop it later on.

@matusvalo matusvalo merged commit 3e5263c into celery:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants