Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non kombu json message decoding in SQS transport #1306

Merged
merged 2 commits into from
Mar 7, 2021
Merged

fix: non kombu json message decoding in SQS transport #1306

merged 2 commits into from
Mar 7, 2021

Conversation

moaddib666
Copy link
Contributor

Fix the case with custom messages decoding in SQS transport
Use cases:

  1. Celery with custom consumer
  2. PUB/SUB with Custom publisher [SNS+SQS]
  3. Non kombu/celery protocols

auvipy
auvipy requested changes Mar 6, 2021
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a test for the changes?

@auvipy auvipy added this to the 5.1.0 milestone Mar 6, 2021
@moaddib666
Copy link
Contributor Author

can you also add a test for the changes?

Hi, sure.

@moaddib666
Copy link
Contributor Author

Updated. Also, I've interested in backporting following changes to the celery 4.* as well, please advise what should be done for it ?

@moaddib666 moaddib666 requested a review from auvipy March 7, 2021 07:15
@moaddib666
Copy link
Contributor Author

Also looks like i would fix the issue described above #1181 (comment)

@auvipy auvipy linked an issue Mar 7, 2021 that may be closed by this pull request
SQS: JSONDecodeError when reading message from Amazon SQS predefined_queues #1181
Closed
@auvipy auvipy merged commit 2a704e3 into celery:master Mar 7, 2021
DayS1eeper pushed a commit to Scalr/kombu that referenced this pull request Jan 18, 2023
@moaddib666 @DayS1eeper
SCALRCORE-24745 CHERRY-PICK fix: non kombu json message decoding in S…
994bc4b 
…QS transport celery#1306 from git@github.com:celery/kombu.git
@DayS1eeper DayS1eeper mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
Component: Amazon SQS Broker PR Type: Bugfix
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

SQS: JSONDecodeError when reading message from Amazon SQS predefined_queues
3 participants
@moaddib666 @auvipy @thedrow