SQS Broker - handle STS authentication with AWS #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2021
auvipy
requested changes
Mar 24, 2021
|
@auvipy Will add tests later today |
|
@galCohen88 FYI, I've invited you to the team. |
thedrow
requested changes
Mar 24, 2021
There's a label for requiring the user to add tests. I just added it. |
Co-authored-by: Omer Katz <omer.drow@gmail.com>
…galCohen88/kombu into issue-1321-sqs-with-sts-session-refresh
thedrow
reviewed
Mar 25, 2021
|
I need to review the documentation but overall this looks good. |
auvipy
approved these changes
Mar 28, 2021
thedrow
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STS token requires being refreshed after certain period of time.
In the PR I added the functionality of creating the token and refreshing it once timeout reached
Link to issue: #1321