Remove use of OrderedDict in various places #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Jan 25, 2022
atombrella
commented
Jan 26, 2022
thedrow
requested changes
Jan 26, 2022
kombu/transport/virtual/base.py
Outdated
Comment on lines
180
to
181
| # Because we set an attribute on the OrderedDict, which | ||
| # is not possible with an ordinary dictionary |
There was a problem hiding this comment.
Please rephrase the comment as it isn't using proper English.
There was a problem hiding this comment.
Is this better? I'd prefer not to trigger pipelines just for this.
# Standard Python dictionaries do not support setting attributes
# on the object, hence the use of OrderedDict
There was a problem hiding this comment.
I pushed that change.
atombrella
changed the title
This requires more work to convert, due to a hack in how the dictionary is used.
It's also problematic, and caused tests to fail.
for more information, see https://pre-commit.ci
atombrella
force-pushed
the
ordered_dict_python27
branch
from
57df2bb
to
205044c
Compare
auvipy
approved these changes
Jan 30, 2022
keithgg
pushed a commit
to open-craft/kombu
that referenced
this pull request
Aug 11, 2022
* Remove use of OrderedDict in Connection.info. * Remove remnant use of collections.OrderedDict * Undo QoS._delivered move to Python standard dictionary. This requires more work to convert, due to a hack in how the dictionary is used. * Undo LRUCache.data to dict conversion. It's also problematic, and caused tests to fail. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert QoS._delivered comment chagne. * Update comment Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.