Added global_keyprefix support for pubsub clients #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What kind of help do you need with the testing? |
|
@thedrow |
Closed
18 tasks
thedrow
reviewed
Feb 28, 2022
t/unit/transport/test_redis.py
Outdated
| channel.active_fanout_queues.add('a') | ||
|
|
||
| channel._subscribe() | ||
| mock_execute_command.assert_called() |
There was a problem hiding this comment.
Why do we need assert_called if we have assert_called_with?
thedrow
requested changes
Feb 28, 2022
| @@ -217,7 +217,7 @@ def _prefix_args(self, args): | |||
| if command in self.PREFIXED_SIMPLE_COMMANDS: | |||
| args[0] = self.global_keyprefix + str(args[0]) | |||
|
|
|||
| if command in self.PREFIXED_COMPLEX_COMMANDS.keys(): | |||
| elif command in self.PREFIXED_COMPLEX_COMMANDS: | |||
There was a problem hiding this comment.
Remove the line break please. It was there because these conditions where unrelated although you are right, they should be.
auvipy
approved these changes
Feb 28, 2022
abellotti
added a commit
to cloudigrade/cloudigrade
that referenced
this pull request
Mar 11, 2022
the fix from celery/kombu#1495 This fixes the issue where task events from the cloudigrade worker were not seen by the internal celery metrics. High level: With kombu 5.2.3, redis client psubscribes are not subscribed to a channel named with the global_keyprefix that we specified with the broker_transport options. However, task and worker events are keyed with the prefix, so they are never seen by the celery metrics. Removing the global_keyprefix (i.e. user prefix via CLOUDIGRADE_ENVIRONMENT) events now are properly seen, but this won't work with a shared redis instance. With the fix in the PR mentioned above, the global_keyprefix is properly handled with pubsub clients.
abellotti
added a commit
to cloudigrade/cloudigrade
that referenced
this pull request
Mar 11, 2022
the fix from celery/kombu#1495 This fixes the issue where task events from the cloudigrade worker were not seen by the internal celery metrics. High level: With kombu 5.2.3, redis client psubscribes are not subscribed to a channel named with the global_keyprefix that we specified with the broker_transport options. However, task and worker events are keyed with the prefix, so they are never seen by the celery metrics. Removing the global_keyprefix (i.e. user prefix via CLOUDIGRADE_ENVIRONMENT) events now are properly seen, but this won't work with a shared redis instance. With the fix in the PR mentioned above, the global_keyprefix is properly handled with pubsub clients.
abellotti
added a commit
to abellotti/celery-exporter
that referenced
this pull request
Mar 23, 2022
This version includes: celery/kombu#1495 which fixes an issue where pubsub clients would not work with messages that include the global_keyprefix.
danihodovic
pushed a commit
to danihodovic/celery-exporter
that referenced
this pull request
Mar 23, 2022
This version includes: celery/kombu#1495 which fixes an issue where pubsub clients would not work with messages that include the global_keyprefix.
keithgg
pushed a commit
to open-craft/kombu
that referenced
this pull request
Aug 11, 2022
* Added global_keyprefix support for pubsub clients * Added test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
Need help with testcases.