SQS: Fix message arg in backoff policy #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmarczak
force-pushed
the
fix-message-arg-in-sqs
branch
from
5cecf9a
to
f48da2c
Compare
auvipy
requested changes
Feb 27, 2022
thedrow
requested changes
Feb 27, 2022
matmarczak
force-pushed
the
fix-message-arg-in-sqs
branch
2 times, most recently
from
aff069e
to
9400f49
Compare
matmarczak
force-pushed
the
fix-message-arg-in-sqs
branch
from
9400f49
to
8e19eca
Compare
auvipy
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I just found an error in SQS implementation regarding backoff tasks. There was already notion of this here or here. I still experience this problem when backoff policy is defined explicitly. Prepared small example to reproduce issue. Fix is in this PR.
I'm open to comments and happy to improve this PR!
Error is here:
err.txt