fix typing flake8

[auvipy]

No description provided.

[auvipy]

@Kludex aren't the pre-commit not recognizing future annotation imports? is it possible to configure CI?

[Kludex]

I didn't understand the question. Based on what are you asking that? What is this PR doing exactly? 🤔

EDIT: Ah! You mean the pre-commit ci thing. Checking.

[Kludex]

Need to add --py39-plus I guess? https://github.com/asottile/pyupgrade#pep-585-typing-rewrites

[Kludex]

Hold on... I didn't get it. What's wrong with the changes on the pre-commit? 🤔 The previous type annotation was correct.

[auvipy]

yes

[Kludex]

By previous I mean that the current master branch has the right type annotation. 🤔

[auvipy]

this was right what you are talking, 1a7b9c4 right?

[Kludex]

I'm not understanding, sorry.

There are two commits on the matcher.py file:

• Mine: 1a7b9c4
• Pre-commit auto-fixes from yesterday: 008b8f7

I don't understand what triggered pre-commit CI for that file yesterday, but the annotation it provides is correct.

The replacement below is just fine:

-        self._matchers: Dict[str, MatcherFunction] = {}
-        self._default_matcher: Optional[MatcherFunction] = None
+        self._matchers: dict[str, MatcherFunction] = {}
+        self._default_matcher: MatcherFunction | None = None

The only problem is that types like Optional, Dict, etc. were not removed from this file.

You can use the dict notation instead of Dict and | (pipe) instead of Optional if you're using __future__.annotations.

[lgtm-com]

This pull request fixes 1 alert when merging 6edc2b7 into e97223f - view on LGTM.com

fixed alerts:

• 1 for Unused import