azure service bus: add type annotations and use cached property #1640
Conversation
| @@ -229,7 +227,7 @@ def _delete(self, queue: str, *args, **kwargs) -> None: | |||
| """Delete queue by name.""" | |||
| queue = self.entity_name(self.queue_name_prefix + queue) | |||
|
|
|||
| self._queue_mgmt_service.delete_queue(queue) | |||
| self.queue_mgmt_service.delete_queue(queue) | |||
There was a problem hiding this comment.
This is the change that I called out in the PR description. I'm not sure if this was accessing the variable instead of using the method intentionally or was an accident.
|
the additional changes here is causing service request error in the tests |
Thanks for bringing that to my attention. That's why this is marked as a draft. I am planning to refactor the tests sometime this week. |
jasonwbarnett
force-pushed
the
annotate/azure-service-bus
branch
3 times, most recently
from
2b2aaed
to
7eb0854
Compare
|
@auvipy this is ready for review 👀 |
jasonwbarnett
force-pushed
the
annotate/azure-service-bus
branch
3 times, most recently
from
646bbdc
to
9fc5e44
Compare
|
Can you please rebase so that the tests would run? |
@thedrow this MR is already rebased off of |
jasonwbarnett
force-pushed
the
annotate/azure-service-bus
branch
from
9fc5e44
to
a8e545f
Compare
|
@thedrow I overlooked what your intent was. I just amended the commit and re-pushed. |
Title is self explanatory.
I converted some instance methods from
@propertyto@cached_propertybecause it's less verbose and I assumed that was the actual intent.There is one underlying change too which I can't tell if it was a bug or by design, I'd like someone else to review to make sure I'm not changing the intended behavior.