-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mongodb transport obsolete calls #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you used delete one and delete many, on theory they seem to be OK. but I'm not sure about the CI failures. can you please recheck?
The CI failures seems unrelated to the changes (failing dependency install of |
In the case of delete matching by |
restarted the builld |
Seems related to the following: |
uggh have to find out what to clean from the CI |
but pytest-cov should not be affected |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please pull from main branch?
thanks a lot |
changes
remove
bydelete_one
spec
to check valid methods corresponding to the real objects(
AttributeError
raised if real class does not have this attribute/method)tests
Validated with latest celery using
celery inspect
calls that were failing before this fix.references
pymongo>=4
#1689