Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(requirements): improve requirements management #1710

Merged
merged 2 commits into from
May 16, 2023
Merged

chore(requirements): improve requirements management #1710

merged 2 commits into from
May 16, 2023

Conversation

stegayet
Copy link
Contributor

@stegayet stegayet commented May 11, 2023 •
edited
Loading

Improvements found while I was working on #1705.

This PR:

  • gets rid of Python 2 specific requirements as kombu does not support this version anymore (unused across the repository).
  • unifies Linux and Windows test dependencies by adding platform markers in test-ci.txt and getting rid of test-ci-windows.txt.

Diff between test-ci.txt and test-ci-windows.txt:

>> diff requirements/test-ci.txt requirements/test-ci-windows.txt        main ✭
1a2
> codecov
3d3
< -r extras/mongodb.txt
8d7
< -r extras/sqs.txt
9a9
> -r extras/librabbitmq.txt

@stegayet stegayet force-pushed the chore/improve-requirements-management branch from 2d5956a to 958ff09 Compare May 11, 2023 21:17
@stegayet stegayet marked this pull request as ready for review May 11, 2023 21:19
@auvipy auvipy self-requested a review May 13, 2023 01:22
@Nusnus Nusnus self-requested a review May 13, 2023 20:13
@stegayet stegayet force-pushed the chore/improve-requirements-management branch from 958ff09 to 79269b0 Compare May 14, 2023 14:03
auvipy
auvipy requested changes May 14, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better but I will cross check before merge

@stegayet stegayet force-pushed the chore/improve-requirements-management branch from 79269b0 to 2e2c6d1 Compare May 15, 2023 09:01
auvipy
auvipy requested changes May 16, 2023
View reviewed changes
requirements/test-ci.txt
@@ -1,11 +1,15 @@
pytest-cov
codecov; sys_platform == 'win32'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be win32 or !win32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be win32 as this is windows specific as per current test-ci-windows.txt

@auvipy auvipy added this to the 5.3 milestone May 16, 2023
@auvipy auvipy merged commit 2ebb698 into celery:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@Nusnus Nusnus Awaiting requested review from Nusnus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@stegayet @auvipy