Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share inclusion proofs for PFB txs #1243

Closed
rootulp opened this issue Jan 16, 2023 · 2 comments
Closed

Fix share inclusion proofs for PFB txs #1243

rootulp opened this issue Jan 16, 2023 · 2 comments
Assignees
@rootulp
Milestone
Incentivized Testnet

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 16, 2023 •
edited
Loading

Context

We have two in-flight PRs:

  1. feat: add shares inclusion proofs #1233
  2. feat!: write PFB txs to their own namespace #1228

Moving PFB transactions to a dedicated namespace will break share inclusion proofs for transactions and PFB transactions so regardless of the order these PRs merge, we will need a follow-up PR to fix share inclusion proofs.
@rootulp rootulp self-assigned this Jan 16, 2023
@rootulp rootulp mentioned this issue Jan 16, 2023
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 17, 2023 •
edited
Loading

Related #703 and celestiaorg/celestia-core#920

rootulp added a commit that referenced this issue Jan 18, 2023
@rootulp
feat!: write PFB txs to their own namespace (#1228)
b6e2651 
Closes #1173,
#1237
Opens #1243
@rootulp rootulp added this to the Incentivized Testnet Stretch milestone Jan 19, 2023
@rootulp rootulp mentioned this issue Jan 19, 2023
Closed
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 24, 2023

Closing in favor of celestiaorg/celestia-core#920

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
cmwaters pushed a commit to celestiaorg/go-square that referenced this issue Dec 14, 2023
@rootulp
feat!: write PFB txs to their own namespace (#1228)
2030e00 
Closes celestiaorg/celestia-app#1173,
celestiaorg/celestia-app#1237
Opens celestiaorg/celestia-app#1243
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
feat!: write PFB txs to their own namespace (#1228)
69c603e 
Closes celestiaorg/celestia-app#1173,
celestiaorg/celestia-app#1237
Opens celestiaorg/celestia-app#1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
Incentivized Testnet
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes