Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document QGB verify command usage #1254

Closed
Tracked by #1257
rach-id opened this issue Jan 17, 2023 · 0 comments · Fixed by #1287
Closed
Tracked by #1257

Document QGB verify command usage #1254

rach-id opened this issue Jan 17, 2023 · 0 comments · Fixed by #1287
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@rach-id
Copy link
Member

rach-id commented Jan 17, 2023

As discussed under #1236 (review), we should write some documentation over the usage of the verification command.

@rach-id rach-id self-assigned this Jan 17, 2023
@rach-id rach-id added the documentation Improvements or additions to documentation label Jan 17, 2023
rach-id added a commit that referenced this issue Jan 31, 2023
## Overview
Closes #1254

We could add more documentation after executing the command to give an
example output, but I guess it's better to do it after we have mocked
QGB deployed so that we have the same output as users.

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
evan-forbes pushed a commit that referenced this issue Feb 27, 2023
## Overview
Closes #1254

We could add more documentation after executing the command to give an
example output, but I guess it's better to do it after we have mocked
QGB deployed so that we have the same output as users.

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
## Overview
Closes celestiaorg/celestia-app#1254

We could add more documentation after executing the command to give an
example output, but I guess it's better to do it after we have mocked
QGB deployed so that we have the same output as users.

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant