Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proposer-based rewards to 0% #1589

Closed
liamsi opened this issue Mar 31, 2023 · 1 comment · Fixed by celestiaorg/cosmos-sdk#309 or #1644
Closed

Set proposer-based rewards to 0% #1589

liamsi opened this issue Mar 31, 2023 · 1 comment · Fixed by celestiaorg/cosmos-sdk#309 or #1644
Assignees
@rootulp
Labels
good first issue Good for newcomers

Comments

@liamsi
Copy link
Member

liamsi commented Mar 31, 2023 •
edited
Loading

Param is removed in the latest version of the SDK. In case we launch with 0.46, we should set the param to 0. It over-proportionally rewards proposers and leads to more centralization.

ref: cosmos/cosmos-sdk#12876
@evan-forbes evan-forbes added this to the Mainnet milestone Apr 2, 2023
@evan-forbes evan-forbes added good first issue Good for newcomers defaults and removed needs:triage labels Apr 2, 2023
@rootulp rootulp changed the title Set bonus proposer reward to 0% Set proposer-based rewards to 0% Apr 20, 2023
@rootulp
Copy link
Collaborator

rootulp commented Apr 20, 2023

Note this issue applies to both: BaseProposerReward and BonusProposerReward because both are deprecated.

In case we launch with 0.46

We decided at the most recent on-site that we are launching mainnet with v0.46.x so this issue is needed before Mainnet.

@rootulp rootulp self-assigned this Apr 20, 2023
@rootulp rootulp mentioned this issue Apr 20, 2023
Merged
@rootulp rootulp reopened this Apr 21, 2023
@rootulp rootulp mentioned this issue Apr 21, 2023
Merged
rootulp added a commit that referenced this issue Apr 24, 2023
@rootulp
chore: upgrade to cosmos-sdk v1.10.0-sdk-v0.46.11 (#1644)
bba1852 
Closes #1589
rootulp added a commit to rootulp/celestia-app that referenced this issue May 2, 2023
@rootulp
chore: upgrade to cosmos-sdk v1.10.0-sdk-v0.46.11 (celestiaorg#1644)
4e98e4a 
Closes celestiaorg#1589
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
chore: upgrade to cosmos-sdk v1.10.0-sdk-v0.46.11 (#1644)
b0b9eb3 
Closes celestiaorg/celestia-app#1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@rootulp @liamsi @evan-forbes