Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeouts in cli to match long block times #256

Closed
Tracked by #669
evan-forbes opened this issue Mar 29, 2022 · 3 comments · Fixed by #892
Closed
Tracked by #669

Increase timeouts in cli to match long block times #256

evan-forbes opened this issue Mar 29, 2022 · 3 comments · Fixed by #892

Comments

@evan-forbes
Copy link
Member

Currently, when using the --broadcast-mode block flag, the block times on a live network are too long, resulting the cli almost always timing out. We need to communicate this to the user in some way, along with increasing timeouts to be useful
@evan-forbes evan-forbes mentioned this issue Jul 1, 2022
Closed
41 tasks
@evan-forbes evan-forbes mentioned this issue Aug 26, 2022
Closed
9 tasks
@rahulghangas
Copy link
Contributor

There's this for reference cosmos/cosmos-sdk#3875

@rahulghangas
Copy link
Contributor

If my understanding is correct, timeouts aren't configurable through the cli. Now we have two options, either change the default rpc config in celestia-core or mutate the imported config in celestia-app. Imo any config changes for rpc must be done on the app side

@rahulghangas rahulghangas mentioned this issue Oct 20, 2022
Merged
2 tasks
@evan-forbes
Copy link
Member Author

evan-forbes commented Oct 20, 2022 •
edited
Loading

Imo any config changes for rpc must be done on the app side

agree, I've tried in core before and it breaks a bunch of tests. also it seems more intuitive to change here.

rahulghangas added a commit that referenced this issue Nov 17, 2022
@rahulghangas @rootulp
chore: default rpc params (#892)
a1351c8 
Configure default rpc params to factor in large txns and long block
times

- [x] Closes #256 
- [x] Closes #591

Co-authored-by: Rootul P <rootulp@gmail.com>
rach-id pushed a commit to rach-id/celestia-app that referenced this issue Nov 17, 2022
@rahulghangas @rootulp @rach-id
chore: default rpc params (celestiaorg#892)
96f539f 
Configure default rpc params to factor in large txns and long block
times

- [x] Closes celestiaorg#256 
- [x] Closes celestiaorg#591

Co-authored-by: Rootul P <rootulp@gmail.com>
evan-forbes pushed a commit that referenced this issue Dec 8, 2022
@rahulghangas @rootulp @evan-forbes
chore: default rpc params (#892)
5042c95 
Configure default rpc params to factor in large txns and long block
times

- [x] Closes #256 
- [x] Closes #591

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: default rpc params rahulghangas/celestia-app
2 participants
@rahulghangas @evan-forbes