Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestInterChainAccounts flake #3726

Closed
rootulp opened this issue Jul 23, 2024 · 2 comments · Fixed by #3776
Closed

TestInterChainAccounts flake #3726

rootulp opened this issue Jul 23, 2024 · 2 comments · Fixed by #3776
Assignees
Labels
flake A test flake that occurred on Github CI WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 23, 2024

Context

https://github.com/celestiaorg/celestia-app/actions/runs/10060343647/job/27808858127?pr=3719#step:7:436

Problem

TestInterChainAccounts flaked. First problematic log:

    logger.go:130: 2024-07-23T14:21:57.641Z	INFO	About to start container	{"image": "ghcr.io/cosmos/relayer:v2.4.1", "test_name": "TestInterChainAccounts", "command": "rly tx link celestia-to-gaia --src-port transfer --dst-port transfer --order unordered --version ics20-1 --client-tp 0 --debug --home /home/relayer", "hostname": "TestInterChainAccounts-unfdof", "container": "TestInterChainAccounts-unfdof"}
    inter_chain_accounts_test.go:50: 
        	Error Trace:	/home/runner/work/celestia-app/celestia-app/test/interchain/inter_chain_accounts_test.go:50
        	Error:      	Received unexpected error:
        	            	failed to link path celestia-to-gaia on relayer &{%!s(*relayer.DockerRelayer=&{0xc0005b7b20 {0xc0005b7b20 []} 13c1ee6917ed61ecb7056480c32cc321e8935a2641a8bf6798ac104b7c128d73 0xc000631e00 c22caae0aea1675513ba8ec00386b37e4554bd35f2db9270b341369844ea0a3e TestInterChainAccounts 0xc0014b1800 true <nil> map[celestia:0xc001605e60 gaia:0xc00149aff0] /home/relayer})} between chains celestia and gaia: exit code 1:  2024-07-23T14:21:57.895699Z	debug	Creating client	{"src_chain_id": "gaia", "dst_chain_id": "celestia", "dst_header_height": 8, "trust_period": 1540800}

Proposal

Fix the test so this flake doesn't reoccur

@rootulp rootulp added the flake A test flake that occurred on Github CI label Jul 23, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Aug 7, 2024

This is happening a lot on recent CI runs.

@rootulp rootulp added the WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc label Aug 7, 2024
@rootulp rootulp self-assigned this Aug 12, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Aug 12, 2024

Discussed during core/app sprint planning and decided to disable this from CI and just run it locally when we modify ICA or IBC things.

mergify bot pushed a commit that referenced this issue Aug 20, 2024
Closes #3726

(cherry picked from commit 234dc14)
rootulp added a commit that referenced this issue Aug 20, 2024
Closes #3726

<hr>This is an automatic backport of pull request #3776 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake A test flake that occurred on Github CI WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant