Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the extended data square caching mechanism threadsafe #713

Closed
evan-forbes opened this issue Sep 15, 2022 · 1 comment
Closed

Make the extended data square caching mechanism threadsafe #713

evan-forbes opened this issue Sep 15, 2022 · 1 comment
Assignees
@rahulghangas

Comments

@evan-forbes
Copy link
Member

As discussed in the docs for EDSSubTreeRootCacher, the current mechanism for caching inner nodes is not threadsafe. This is problematic as rsmt2d will soon be parallelized. This is currently blocked by #712, and might also need to be tackled simultaneously. After updating the design to use the new rsmt2d.TreeConstructorFn, we should update the mechanism here to use it to be threadsafe.
@evan-forbes
Copy link
Member Author

this was completed in #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulghangas rahulghangas

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahulghangas @evan-forbes