chore: update to rsmt2d v0.7.0 #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on fixing the remaining tests, as there are non-intuitive things in the wrapper (that we should eventually get rid of...) |
evan-forbes
added
C: Celestia app
consensus breaking
evan-forbes
previously approved these changes
Oct 28, 2022
There was a problem hiding this comment.
I'm approving, but we should probably get someone other than @rahulghangas or myself before merging
rach-id
previously approved these changes
Oct 28, 2022
rach-id
approved these changes
Oct 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #926 +/- ##
==========================================
+ Coverage 26.11% 26.13% +0.01%
==========================================
Files 77 77
Lines 9347 9353 +6
==========================================
+ Hits 2441 2444 +3
- Misses 6677 6680 +3
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rootulp
reviewed
Oct 28, 2022
| }) | ||
| tr := wrapper.NewErasuredNamespacedMerkleTree(uint64(len(row)), 0) | ||
| for _, r := range rowChunk { | ||
| // c := (i * subLeafRange) + j |
There was a problem hiding this comment.
sorry for delayed review but this comment appears residual / safe to delete
rootulp
added a commit
that referenced
this pull request
Oct 28, 2022
rootulp
added a commit
that referenced
this pull request
Oct 30, 2022
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Updates dependency of rsmt2d to v0.7.0 Changes relevant constructors/methods to update to new definition of rsmt2d.TreeConstructorFn - [x] Closes celestiaorg#712 - [x] Closes celestiaorg#754 Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com> Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com> Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Updates dependency of rsmt2d to v0.7.0 Changes relevant constructors/methods to update to new definition of rsmt2d.TreeConstructorFn - [x] Closes celestiaorg#712 - [x] Closes celestiaorg#754 Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com> Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com> Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
cmwaters
pushed a commit
to celestiaorg/go-square
that referenced
this pull request
Dec 14, 2023
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependency of rsmt2d to v0.7.0
Changes relevant constructors/methods to update to new definition of rsmt2d.TreeConstructorFn