Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: increase number of reserved bytes to two #883

Closed
Tracked by #650
rootulp opened this issue Oct 18, 2022 · 2 comments
Closed
Tracked by #650

specs: increase number of reserved bytes to two #883

rootulp opened this issue Oct 18, 2022 · 2 comments
Assignees
Labels
specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 18, 2022

Problem

#850 increased the share size and the number of reserved bytes from 1 to 2:

// CompactShareReservedBytes is the number of bytes reserved for the location of
// the first unit (transaction, ISR, evidence) in a compact share.
CompactShareReservedBytes = 2

so the specs are now inaccurate

| `SHARE_RESERVED_BYTES` | `uint64` | `1` | `byte` | Bytes reserved at the beginning of each [share](data_structures.md#share). Must be sufficient to represent `SHARE_SIZE`. |

Proposal

  1. Update the share size constant from 256 to 512 bytes
  2. Update the num reserved bytes constant from 1 to 2
  3. Update the diagrams and text in the Share section
@rootulp rootulp added the specs directly relevant to the specs label Oct 18, 2022
@rootulp rootulp self-assigned this Oct 18, 2022
@rootulp
Copy link
Collaborator Author

rootulp commented Oct 18, 2022

This is blocked on #856

rootulp added a commit that referenced this issue Nov 24, 2022
Closes #883

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@evan-forbes
Copy link
Member

closed by #939

0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
Closes celestiaorg/celestia-app#883

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specs directly relevant to the specs
Projects
None yet
Development

No branches or pull requests

2 participants