Switch usage from EmitEvent to EmitTypedEvent

[rahulghangas]

Summary

Change EmitEvent in favour of EmitTypedEvent

Problem Definition

EmitEvent has been deprecated

Proposal

We should switch to EmitTypedEvent and define relavnt type(s) in protobuf. Changes need to be done both in payment and qgb module, primarily x/payment/keeper/keeper.go and x/qgb/keeper/keeper_attestation.go

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[evan-forbes]

this will be a nice improvement. After #954, the only instance should be the payment module as listed above.

[vidhanarya]

I can pick this up, have a few doubts though (taking the example of SetAttestationRequest):

• Is any downstream service consuming from this event AttestationRequest (Idea is to change event name to EventAttestationRequest)
• For reference can someone point me to a relevant doc/ADR for this flow (data store)

Thinking of implementing message and event as below

message AttestationRequest {
  string module = 1;
  string nonce = 2;
}

ctx.EventManager().EmitTypedEvent(&qgb.AttestationRequest{
	Module: types.ModuleName,
	Nonce:  fmt.Sprint(at.GetNonce()),
})

Open to suggestion if you have something else in mind @rahulghangas @evan-forbes

[rahulghangas]

@vidhanarya

Is any downstream service consuming from this event AttestationRequest (Idea is to change event name to EventAttestationRequest)

Yes, events are consumed by other services

Also, I don't think there's a need to change the qgb event, since we're doing some major refactoring to the qgb module (see Evan's comment above)

[vidhanarya]

So as a part of this issue, we only want to change payment module i.e. payfordata event?

[rahulghangas]

yessir