-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document NMT wrapper in prepare_proposal #1039
Conversation
@evan-forbes Is this still worth merging? |
sure, but lets stay consistent with the naming #1069 (comment) |
# Conflicts: # pkg/da/data_availability_header.go
2e7c11e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for letting this slip through the cracks @sweexordious
left one comment to use the same name for the wrapper across the board, then should finally merge
@evan-forbes done, all we need is an approve :D |
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
- Coverage 48.84% 48.26% -0.59%
==========================================
Files 75 77 +2
Lines 4369 4397 +28
==========================================
- Hits 2134 2122 -12
- Misses 2055 2098 +43
+ Partials 180 177 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Adds a small note to specify that the NMT wrapper is used to extend the shares
Adds a small note to specify that the NMT wrapper is used to extend the shares