-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 011 - Optimistic Blob Size Independent Inclusion Proofs and PFB Fraud Proofs #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for prematurely reviewing a draft PR, I get excited when I see your ADRs
...tecture/adr-010-optimistic-message-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...tecture/adr-010-optimistic-message-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...tecture/adr-010-optimistic-message-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feedback is mostly questions for me to better understand
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
...chitecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfd-fraud-proofs.md
Outdated
Show resolved
Hide resolved
Here's my attempt at a tl;dr of this: This doesn't require any consensus-critical changes to celestia-core/app though however, right? Also the fraud proof could be done on the rollup/rollmint level. |
@evan-forbes The ADR does not change core because we declined on doing optimization 1 & 2 as it is not that good for a tradeoff for the effort. That's why there is no blocker in merging this imo. |
Overview
This PR Looks at the possibility to use pfd-transactions for message inclusion proofs. It also introduces pfd-fraud-proofs.
rendered
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->