Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch default keyring backend #1141

Conversation

rahulghangas
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Merging #1141 (7bb4bba) into main (c16d6e7) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   47.98%   48.27%   +0.28%     
==========================================
  Files          71       71              
  Lines        3995     3994       -1     
==========================================
+ Hits         1917     1928      +11     
+ Misses       1909     1899      -10     
+ Partials      169      167       -2     
Impacted Files Coverage Δ
pkg/shares/share_splitting.go 73.56% <100.00%> (+13.33%) ⬆️
x/blob/types/payforblob.go 80.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rahulghangas rahulghangas self-assigned this Dec 20, 2022
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I also built it locally and can see it has changed:

Flags:
  -h, --help                     help for keys
      --keyring-backend string   Select keyring's backend (os|file|test) (default "file")
      --keyring-dir string       The client Keyring directory; if omitted, the default 'home' directory will be used
      --output string            Output format (text|json) (default "text")

@rahulghangas rahulghangas merged commit dab3e63 into celestiaorg:main Dec 20, 2022
@rahulghangas rahulghangas deleted the chore/switch-keyring-backend-default branch December 20, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants