Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove ShareCommitAndSignature #1270

Merged
merged 1 commit into from
Jan 20, 2023
Merged

chore!: remove ShareCommitAndSignature #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions proto/blob/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,13 @@ service Msg {
}
}

// ShareCommitAndSignature defines the
message ShareCommitAndSignature {
// share_commitment is the root of a binary Merkle tree that has leaves which
// are subtree roots of the relevant blob shares in the original data
// square.
bytes share_commitment = 2;
bytes signature = 3; // signature on one SignedTransactionPayForBlob
}

// MsgPayForBlob pays for the inclusion of a blob in the block.
message MsgPayForBlob {
string signer = 1;
repeated bytes namespace_ids = 2;
repeated uint32 blob_sizes = 3;
// share_commitment is the share_commitment from
// ShareCommitAndSignature that will be included in a block
// share_commitment is a commitment to the blob shares associated with this
// MsgPayForBlob.
Comment on lines +22 to +23
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can elaborate on this in x/blob/README.md and especially after #1231

bytes share_commitment = 4;
// share_versions are the versions of the share format that the blobs
// associated with this message should use when included in a block. The
Expand Down
287 changes: 28 additions & 259 deletions x/blob/types/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.