-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert!: multi share commitment #1275
revert!: multi share commitment #1275
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
+ Coverage 48.85% 48.99% +0.13%
==========================================
Files 75 75
Lines 4368 4358 -10
==========================================
+ Hits 2134 2135 +1
+ Misses 2054 2043 -11
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -61,10 +61,10 @@ func (msg *MsgPayForBlob) Type() string { | |||
// ValidateBasic fulfills the sdk.Msg interface by performing stateless | |||
// validity checks on the msg that also don't require having the actual blob | |||
func (msg *MsgPayForBlob) ValidateBasic() error { | |||
if len(msg.NamespaceIds) != len(msg.ShareVersions) || len(msg.NamespaceIds) != len(msg.BlobSizes) { | |||
if len(msg.NamespaceIds) != len(msg.ShareVersions) || len(msg.NamespaceIds) != len(msg.BlobSizes) || len(msg.NamespaceIds) != len(msg.ShareCommitments) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to add a check that this length is not zero?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this length are you referring to msg.ShareCommitments or msg.NamespaceIds? So something like this:
if len(msg.NamespaceIds) == 0 {
return ErrNoNamespaceIds
}
or
if len(msg.ShareCommitments) == 0 {
return ErrNoShareCommitments
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO both would work. We could include checks that all of these fields are non-zero: NamespaceIds, ShareVersions, BlobSizes, and ShareCommitments. Will do in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, LGTM 👍 👍 other than Callum's comment
16, 5, | ||
16, 11, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[simple comment]
perhaps we can eventually include some some option to use a multiblob commit and no namespaces to be more efficient in the future
refactor: rename stripCompactShares to stripPrefix chore: rename to NewShareInclusionProof feat!: keep track of share indexes when splitting txs fix lint wip: test write tx revert!: multi share commitment (celestiaorg#1275) Closes celestiaorg#1231 feat: Add QGB verification command (celestiaorg#1236) This command verifies that some shares were attested to in the QGB smart contract. Blocked by celestiaorg#1233 Closes celestiaorg#1184 <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords feat: check that `MsgPayForBlob` components are non-zero (celestiaorg#1279) feat: compact share splitter tracks tx share ranges test: TestExport_txKeyToShareIndex extract mergeMaps fix lint test: TxSharePosition test NewTxInclusionProof fix comment delete unused file wip: TestSplitTxs improve largeTx test case fix: shift pfbTxShare range by len of txShares refactor: use css.Count() for end share index refactor: rename to shareRanges feat: enforce that PFBs are always ordered after normal transactions (celestiaorg#1273) Closes: celestiaorg#1230 chore(deps): Bump github.com/celestiaorg/nmt from 0.12.0 to 0.13.0 (celestiaorg#1284) fix: IsCompactShare for PFB tx shares (celestiaorg#1281) Closes celestiaorg#1280 chore: fix naming from `client/cli/wirepayfordata.go` to blob (celestiaorg#1288) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> After updating my forks, I've seen that `wirepayfordata` haven't received renaming treatment. Hence this PR solves this little thingy. We can also have naming like `wirepayfordatablob`. Still LMK if you prefer the later <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords chore: rename message to blob in QGB verify command (celestiaorg#1289) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords sanity check that raw data is in shares fix lint NewTxInclusionProof returns a TxProof fix: lint Update pkg/prove/proof.go Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Update pkg/shares/split_compact_shares.go Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> refactor: remove err return param chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (celestiaorg#1283) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's releases</a>.</em></p> <blockquote> <h2>v3.4.0</h2> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.42.0 to 5.42.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/601">golangci/golangci-lint-action#601</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.42.0 to 5.42.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/602">golangci/golangci-lint-action#602</a></li> <li>build(deps-dev): bump eslint from 8.27.0 to 8.28.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/604">golangci/golangci-lint-action#604</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.42.1 to 5.43.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/605">golangci/golangci-lint-action#605</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.42.1 to 5.43.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/607">golangci/golangci-lint-action#607</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.43.0 to 5.44.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/609">golangci/golangci-lint-action#609</a></li> <li>build(deps-dev): bump prettier from 2.7.1 to 2.8.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/611">golangci/golangci-lint-action#611</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.43.0 to 5.44.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/610">golangci/golangci-lint-action#610</a></li> <li>build(deps-dev): bump typescript from 4.8.4 to 4.9.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/606">golangci/golangci-lint-action#606</a></li> <li>build(deps): bump <code>@types/node</code> from 18.11.9 to 18.11.10 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/614">golangci/golangci-lint-action#614</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.44.0 to 5.45.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/615">golangci/golangci-lint-action#615</a></li> <li>build(deps-dev): bump eslint from 8.28.0 to 8.29.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/617">golangci/golangci-lint-action#617</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.44.0 to 5.45.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/616">golangci/golangci-lint-action#616</a></li> <li>build(deps-dev): bump typescript from 4.9.3 to 4.9.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/619">golangci/golangci-lint-action#619</a></li> <li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.34.0 to 0.36.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/620">golangci/golangci-lint-action#620</a></li> <li>build(deps-dev): bump prettier from 2.8.0 to 2.8.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/622">golangci/golangci-lint-action#622</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.45.0 to 5.46.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/621">golangci/golangci-lint-action#621</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.45.0 to 5.46.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/623">golangci/golangci-lint-action#623</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.46.0 to 5.46.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/625">golangci/golangci-lint-action#625</a></li> <li>build(deps): bump <code>@types/node</code> from 18.11.10 to 18.11.17 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/628">golangci/golangci-lint-action#628</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.46.0 to 5.46.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/626">golangci/golangci-lint-action#626</a></li> <li>build(deps-dev): bump eslint from 8.29.0 to 8.30.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/627">golangci/golangci-lint-action#627</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.46.1 to 5.47.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/633">golangci/golangci-lint-action#633</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.46.1 to 5.47.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/634">golangci/golangci-lint-action#634</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.0.6 to 3.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/632">golangci/golangci-lint-action#632</a></li> <li>build(deps-dev): bump eslint from 8.30.0 to 8.31.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/635">golangci/golangci-lint-action#635</a></li> <li>build(deps): bump <code>@types/node</code> from 18.11.17 to 18.11.18 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/636">golangci/golangci-lint-action#636</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.47.0 to 5.47.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/637">golangci/golangci-lint-action#637</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.47.0 to 5.47.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/639">golangci/golangci-lint-action#639</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.1.0 to 3.1.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/638">golangci/golangci-lint-action#638</a></li> <li>build(deps): bump json5 from 1.0.1 to 1.0.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/642">golangci/golangci-lint-action#642</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.47.1 to 5.48.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/643">golangci/golangci-lint-action#643</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.47.1 to 5.48.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/644">golangci/golangci-lint-action#644</a></li> <li>build(deps-dev): bump prettier from 2.8.1 to 2.8.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/645">golangci/golangci-lint-action#645</a></li> <li>build(deps-dev): bump eslint-config-prettier from 8.5.0 to 8.6.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/646">golangci/golangci-lint-action#646</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.1.1 to 3.1.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/647">golangci/golangci-lint-action#647</a></li> <li>Support Caching in Mono Repo by <a href="https://github.com/bbernays"><code>@bbernays</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/629">golangci/golangci-lint-action#629</a></li> <li>build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.27.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/650">golangci/golangci-lint-action#650</a></li> <li>build(deps-dev): bump prettier from 2.8.2 to 2.8.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/651">golangci/golangci-lint-action#651</a></li> <li>build(deps-dev): bump eslint from 8.31.0 to 8.32.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/652">golangci/golangci-lint-action#652</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.0 to 5.48.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/653">golangci/golangci-lint-action#653</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.0 to 5.48.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/654">golangci/golangci-lint-action#654</a></li> <li>build(deps-dev): bump eslint-plugin-import from 2.27.4 to 2.27.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/655">golangci/golangci-lint-action#655</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.1 to 5.48.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/656">golangci/golangci-lint-action#656</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.1 to 5.48.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/657">golangci/golangci-lint-action#657</a></li> <li>build(deps-dev): bump eslint-plugin-simple-import-sort from 8.0.0 to 9.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/658">golangci/golangci-lint-action#658</a></li> </ul> <h2>New Contributors</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint-action/commit/08e2f20817b15149a52b5b3ebe7de50aff2ba8c5"><code>08e2f20</code></a> build(deps-dev): bump eslint-plugin-simple-import-sort from 8.0.0 to 9.0.0 (#...</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/8d110786c7428017295d1011939074e4880134c5"><code>8d11078</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.1 to 5.48.2 ...</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/724a5425dbb3605c8193e1236b39684908fe1faf"><code>724a542</code></a> build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.1 to 5.48.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/656">#656</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/ac0edcd804b1b5a5a373d15812e3ca8e3009aaff"><code>ac0edcd</code></a> build(deps-dev): bump eslint-plugin-import from 2.27.4 to 2.27.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/655">#655</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/d6404ce2933838656ca2d23ed1d7c9bf7177e38b"><code>d6404ce</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.0 to 5.48.1 ...</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/cb88bde406513ba2b8f95895720d89bf588e2908"><code>cb88bde</code></a> build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.0 to 5.48.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/653">#653</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/f26018a9c0d2934ae3bdaadb0d6bbbbe168f34ac"><code>f26018a</code></a> build(deps-dev): bump eslint from 8.31.0 to 8.32.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/652">#652</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/78451d099ca9433b4b6a0b5d9c7a2d7720928976"><code>78451d0</code></a> build(deps-dev): bump prettier from 2.8.2 to 2.8.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/651">#651</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/5570e667056be8be4c7e99ba31339d64a2c7ab29"><code>5570e66</code></a> build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.27.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/650">#650</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/1626f2bd943cd202b1338d967340eb6c987e5067"><code>1626f2b</code></a> Support Caching in Mono Repo (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/629">#629</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v3.3.1...v3.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golangci/golangci-lint-action&package-manager=github_actions&previous-version=3.3.1&new-version=3.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore!: rename package prove to proof (celestiaorg#1291) Closes celestiaorg#1290 refactor: use WriteTx refactor: remove named return params refactor: use shareRangeOffset update to local celestia-core test: integ tests to use prove=true fix godoc chore: rename sharesProofs to shareProofs Update pkg/shares/share_splitting.go Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com> docs: describe mergeMaps chore: add more test cases for the compact share splitter (celestiaorg#1295) feat: Prevent any errors when creating the data folder (celestiaorg#1303) Hello team, This is an small feature/fix that prevents any error when the container starts and try to create the folder in `${CELESTIA_HOME}/data` using the option `-p` in the `mkdir` command. Thank you! <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords chore!: rename MsgPayForBlob to MsgPayForBlobs (celestiaorg#1304) Closes: celestiaorg#1221 Co-authored-by: Rootul P <rootulp@gmail.com> chore: downgrade nmt to 0.12.0 (celestiaorg#1307) Downgrade to NMT 0.12.0 while @distractedm1nd @liamsi investigate an issue in 0.13.0 chore: rename variable to shareProof lint with --verbose flag update to 1.50.1
Closes #1231