-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ADR 15 Namespace ID Size #1405
docs: ADR 15 Namespace ID Size #1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, makes sense to me! afaiu, nmt, celestia-app, and celestia-node should be able to have larger namespaces with only minor changes here and celestia-node, but I could be wrong.
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Should we not agree on the actual new namespace size before merging this or marking as ready for review? The decision section is empty. |
I was hoping we could reach a decision via feedback on this PR. If you think we need a meeting to decide, I can set one up. |
Will merge by EOD if there is no more feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! left some non-blocking comments.
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments, LGTM!
ADR for #1308