feat(pkg/da): Extract min share creation into separate function for convenience (#1476) #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onvenience (#1476) This PR extracts min share creation into an exported function so that celestia-node can depend on it canonically without duplicating code and risking error. Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Codecov Report
@@ Coverage Diff @@
## v0.13.x #1515 +/- ##
==========================================
Coverage ? 48.36%
==========================================
Files ? 79
Lines ? 4435
Branches ? 0
==========================================
Hits ? 2145
Misses ? 2109
Partials ? 181 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rootulp
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
cherry picks #1476 onto v0.13.0, which is now a fork of the v0.12.x branch
Checklist