chore: bump NMT to v0.15.0 and include testutil/testnode chainID #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to NMT [v0.15.0](https://github.com/celestiaorg/nmt/releases/tag/v0.15.0) which contains improved error handling. Will cherry-pick this to the release branches after this merges: v0.12.x, v0.13.x, v0.14.x
…ctor (celestiaorg#1445) Allows customising the `chainID` of the testnode.
rootulp
added
the
chore
mojtaba-esk
approved these changes
Mar 31, 2023
evan-forbes
reviewed
Mar 31, 2023
Comment on lines
+93
to
+95
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
lol we should fix this interface in rsmt2d as well
There was a problem hiding this comment.
evan-forbes
approved these changes
Mar 31, 2023
rootulp
changed the title
evan-forbes
pushed a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commits to the v0.12.x release branch:
Will create v0.12.2 after this merges