-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create working multistage Dockerfile #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Awesome job! The devops-test compose file looks slick and sick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this Dockerfile is multi-stage and meets the requirements of k8s/compose setup, can we name it something ____.Dockerfile to indicate that this is its main use?
Nits and typos Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
My intention was that this would be the canonical and ideally only Dockerfile needed for this repository. As such I believe we should use the "top level" Dockerfile naming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
Create a new Dockerfile that meets the expectations of both the docker-compose and k8s cluster setups.
This means that the entrypoint to the container is the binary itself (
celestia-appd
in this case) .It is expected that the appropriate arguments are passed to the container as if one was running the binary locally. Configuration isn't baked into the image and is expected to be passed as flags or using volume mounts.
For examples see docker-compose and k8s.
This has been manually tested using the following instructions:
as well as with the
devops-test/devnet/k8s
clustercloses: #153
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes