fix: resolve lint errors

README.md

@@ -10,6 +10,7 @@
 [![GitPOAP Badge](https://public-api.gitpoap.io/v1/repo/celestiaorg/celestia-app/badge)](https://www.gitpoap.io/gh/celestiaorg/celestia-app)
 
 celestia-app is a blockchain application built using parts of the Cosmos stack. celestia-app uses
+
 - [celestiaorg/cosmos-sdk](https://github.com/celestiaorg/cosmos-sdk) a fork of [cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk)
 - [celestiaorg/celestia-core](https://github.com/celestiaorg/celestia-core) a fork of [cometbft/cometbft](https://github.com/cometbft/cometbft)
 

app/app.go

@@ -666,7 +666,7 @@ func (app *App) GetSubspace(moduleName string) paramstypes.Subspace {
 
 // RegisterAPIRoutes registers all application module routes with the provided
 // API server.
-func (app *App) RegisterAPIRoutes(apiSvr *api.Server, apiConfig config.APIConfig) {
+func (app *App) RegisterAPIRoutes(apiSvr *api.Server, _ config.APIConfig) {
 	clientCtx := apiSvr.ClientCtx
 	// Register new tx routes from grpc-gateway.
 	authtx.RegisterGRPCGatewayRoutes(clientCtx, apiSvr.GRPCGatewayRouter)

app/parse_txs.go

@@ -10,7 +10,7 @@ import (
 )
 
 // separateTxs decodes raw tendermint txs into normal and blob txs.
-func separateTxs(txcfg client.TxConfig, rawTxs [][]byte) ([][]byte, []core.BlobTx) {
+func separateTxs(_ client.TxConfig, rawTxs [][]byte) ([][]byte, []core.BlobTx) {
 	normalTxs := make([][]byte, 0, len(rawTxs))
 	blobTxs := make([]core.BlobTx, 0, len(rawTxs))
 	for _, rawTx := range rawTxs {

docs/architecture/adr-020-deterministic-square-construction.md

@@ -36,7 +36,7 @@ Block proposers need not know nor care about the internals of square constructio
 []Tx <=> []Share (ODS) <=> EDS
 ```
 
-Validation in `ProcessProposal` is simplified to reconstructing the square given the transaction set and then evaluating whether the computed data root matches the proposed one. 
+Validation in `ProcessProposal` is simplified to reconstructing the square given the transaction set and then evaluating whether the computed data root matches the proposed one.
 
 ## Detailed Design
 
@@ -57,7 +57,7 @@ For sparse shares i.e. the blobs themselves, the `SparseShareCounter` estimates
 
 With these two structs, we can safely guarantee that all staged transactions can be included in the square and from the estimation can formulate the minimum square size that will be used to calculate the share index for all the blobs. The construction of the square itself remains the same. Additionally, as the share index and square size can be deterministically calculated it no longer needs to be gossiped to all nodes in the consensus network. However, for verifiability purposes the square size should still remain in the `Data` struct.
 
-Both `PrepareProposal` and `ProcessProposal` will as a result, call much the same methods. Verification is thus reduced to: did I create the same square as you, rather than is your version of the square valid. The main difference is that `PrepareProposal` will handle overflow of transactions by discarding them, while `ProcessProposal` will handle overflow by rejecting the block. 
+Both `PrepareProposal` and `ProcessProposal` will as a result, call much the same methods. Verification is thus reduced to: did I create the same square as you, rather than is your version of the square valid. The main difference is that `PrepareProposal` will handle overflow of transactions by discarding them, while `ProcessProposal` will handle overflow by rejecting the block.
 
 The new algorithm will no longer need to check that the blobs are ordered by namespace and that the wrapped PFBs contain the corrext share index. `ProcessProposal` will still need to verify the `BlobTx` format (i.e that each blob has a matching PFB and that the PFBs are correctly signed)
 

test/txsim/blob.go

@@ -58,7 +58,7 @@ func (s *BlobSequence) Init(_ context.Context, _ grpc.ClientConn, allocateAccoun
 	s.account = allocateAccounts(1, fundsForGas)[0]
 }
 
-func (s *BlobSequence) Next(ctx context.Context, querier grpc.ClientConn, rand *rand.Rand) (Operation, error) {
+func (s *BlobSequence) Next(_ context.Context, _ grpc.ClientConn, rand *rand.Rand) (Operation, error) {
 	numBlobs := s.blobsPerPFB.Rand(rand)
 	sizes := make([]int, numBlobs)
 	namespaces := make([]ns.Namespace, numBlobs)

test/util/direct_tx_gen.go

@@ -20,9 +20,9 @@ import (
 // provided configuration. The account info is queried directly from the
 // application. One blob transaction is generated per account provided.
 func RandBlobTxsWithAccounts(
-	t *testing.T,
+	_ *testing.T,
 	capp *app.App,
-	enc sdk.TxEncoder,
+	_ sdk.TxEncoder,
 	kr keyring.Keyring,
 	size int,
 	blobCount int,
@@ -108,8 +108,8 @@ func DirectQueryAccount(app *app.App, addr sdk.AccAddress) authtypes.AccountI {
 // provided configuration. One blob transaction is generated per account
 // provided. The sequence and account numbers are set manually using the provided values.
 func RandBlobTxsWithManualSequence(
-	t *testing.T,
-	enc sdk.TxEncoder,
+	_ *testing.T,
+	_ sdk.TxEncoder,
 	kr keyring.Keyring,
 	size int,
 	blobCount int,
@@ -233,7 +233,7 @@ func SendTxsWithAccounts(
 // account info must be provided.
 func SendTxWithManualSequence(
 	t *testing.T,
-	enc sdk.TxEncoder,
+	_ sdk.TxEncoder,
 	kr keyring.Keyring,
 	fromAcc, toAcc string,
 	amount uint64,

test/util/test_app.go

@@ -61,7 +61,7 @@ var DefaultConsensusParams = &abci.ConsensusParams{
 type emptyAppOptions struct{}
 
 // Get implements AppOptions
-func (ao emptyAppOptions) Get(o string) interface{} {
+func (ao emptyAppOptions) Get(_ string) interface{} {
 	return nil
 }
 

test/util/testnode/node_init.go

@@ -76,7 +76,7 @@ func collectGenFiles(tmCfg *config.Config, encCfg encoding.Config, pubKey crypto
 func initGenFiles(
 	cparams *tmproto.ConsensusParams,
 	state map[string]json.RawMessage,
-	codec codec.Codec,
+	_ codec.Codec,
 	file,
 	chainID string,
 ) error {

testing/e2e/pkg/setup.go

@@ -344,7 +344,7 @@ func WriteAddressBook(peers []string, file string) error {
 	return nil
 }
 
-func MakeAppConfig(node *Node) (*serverconfig.Config, error) {
+func MakeAppConfig(_ *Node) (*serverconfig.Config, error) {
 	srvCfg := serverconfig.DefaultConfig()
 	srvCfg.MinGasPrices = fmt.Sprintf("0.001%s", app.BondDenom)
 	return srvCfg, srvCfg.ValidateBasic()

x/blob/client/cli/query.go

@@ -9,7 +9,7 @@ import (
 )
 
 // GetQueryCmd returns the CLI query commands for this module
-func GetQueryCmd(queryRoute string) *cobra.Command {
+func GetQueryCmd(_ string) *cobra.Command {
 	// Group blob queries under a subcommand
 	cmd := &cobra.Command{
 		Use:                        types.ModuleName,

x/blob/module.go

@@ -62,7 +62,7 @@ func (AppModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage {
 }
 
 // ValidateGenesis performs genesis state validation for the capability module.
-func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncodingConfig, bz json.RawMessage) error {
+func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingConfig, bz json.RawMessage) error {
 	var genState types.GenesisState
 	if err := cdc.UnmarshalJSON(bz, &genState); err != nil {
 		return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err)
@@ -71,11 +71,11 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncod
 }
 
 // RegisterRESTRoutes registers the capability module's REST service handlers.
-func (AppModuleBasic) RegisterRESTRoutes(clientCtx client.Context, rtr *mux.Router) {
+func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {
 }
 
 // RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the module.
-func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
+func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {
 }
 
 // GetTxCmd returns the capability module's root tx command.
@@ -120,7 +120,7 @@ func (am AppModule) Route() sdk.Route {
 func (AppModule) QuerierRoute() string { return types.QuerierRoute }
 
 // LegacyQuerierHandler returns the capability module's Querier.
-func (am AppModule) LegacyQuerierHandler(legacyQuerierCdc *codec.LegacyAmino) sdk.Querier {
+func (am AppModule) LegacyQuerierHandler(_ *codec.LegacyAmino) sdk.Querier {
 	return nil
 }
 

x/qgb/client/verify.go

@@ -303,7 +303,7 @@ func VerifyShares(ctx context.Context, logger tmlog.Logger, config VerifyConfig,
 }
 
 func VerifyDataRootInclusion(
-	ctx context.Context,
+	_ context.Context,
 	qgbWrapper *wrapper.QuantumGravityBridge,
 	nonce uint64,
 	height uint64,

x/qgb/keeper/hooks.go

@@ -33,11 +33,11 @@ func (h Hooks) AfterValidatorBeginUnbonding(ctx sdk.Context, _ sdk.ConsAddress,
 	return nil
 }
 
-func (h Hooks) BeforeDelegationCreated(_ sdk.Context, delAddr sdk.AccAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) BeforeDelegationCreated(_ sdk.Context, _ sdk.AccAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) AfterValidatorCreated(ctx sdk.Context, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterValidatorCreated(_ sdk.Context, _ sdk.ValAddress) error {
 	return nil
 }
 
@@ -53,18 +53,18 @@ func (h Hooks) BeforeDelegationRemoved(_ sdk.Context, _ sdk.AccAddress, _ sdk.Va
 	return nil
 }
 
-func (h Hooks) AfterValidatorRemoved(ctx sdk.Context, _ sdk.ConsAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterValidatorRemoved(_ sdk.Context, _ sdk.ConsAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) BeforeValidatorSlashed(ctx sdk.Context, valAddr sdk.ValAddress, fraction sdk.Dec) error {
+func (h Hooks) BeforeValidatorSlashed(_ sdk.Context, _ sdk.ValAddress, _ sdk.Dec) error {
 	return nil
 }
 
-func (h Hooks) BeforeDelegationSharesModified(ctx sdk.Context, delAddr sdk.AccAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) BeforeDelegationSharesModified(_ sdk.Context, _ sdk.AccAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) AfterDelegationModified(ctx sdk.Context, delAddr sdk.AccAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterDelegationModified(_ sdk.Context, _ sdk.AccAddress, _ sdk.ValAddress) error {
 	return nil
 }

x/qgb/keeper/query_attestation.go

@@ -34,7 +34,7 @@ func (k Keeper) AttestationRequestByNonce(
 
 func (k Keeper) LatestAttestationNonce(
 	ctx context.Context,
-	request *types.QueryLatestAttestationNonceRequest,
+	_ *types.QueryLatestAttestationNonceRequest,
 ) (*types.QueryLatestAttestationNonceResponse, error) {
 	if !k.CheckLatestAttestationNonce(sdk.UnwrapSDKContext(ctx)) {
 		return nil, types.ErrLatestAttestationNonceStillNotInitialized

x/qgb/keeper/query_general.go

@@ -10,14 +10,14 @@ import (
 // LastUnbondingHeight queries the last unbonding height.
 func (k Keeper) LastUnbondingHeight(
 	c context.Context,
-	req *types.QueryLastUnbondingHeightRequest,
+	_ *types.QueryLastUnbondingHeightRequest,
 ) (*types.QueryLastUnbondingHeightResponse, error) {
 	return &types.QueryLastUnbondingHeightResponse{
 		Height: k.GetLastUnBondingBlockHeight(sdk.UnwrapSDKContext(c)),
 	}, nil
 }
 
-func (k Keeper) Params(c context.Context, request *types.QueryParamsRequest) (*types.QueryParamsResponse, error) {
+func (k Keeper) Params(c context.Context, _ *types.QueryParamsRequest) (*types.QueryParamsResponse, error) {
 	params := k.GetParams(sdk.UnwrapSDKContext(c))
 	return &types.QueryParamsResponse{
 		Params: params,

x/qgb/module.go

@@ -61,7 +61,7 @@ func (AppModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage {
 }
 
 // ValidateGenesis performs genesis state validation for the capability module.
-func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncodingConfig, bz json.RawMessage) error {
+func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingConfig, bz json.RawMessage) error {
 	var genState types.GenesisState
 	if err := cdc.UnmarshalJSON(bz, &genState); err != nil {
 		return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err)
@@ -70,11 +70,11 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncod
 }
 
 // RegisterRESTRoutes registers the capability module's REST service handlers.
-func (AppModuleBasic) RegisterRESTRoutes(clientCtx client.Context, rtr *mux.Router) {
+func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {
 }
 
 // RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the module.
-func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
+func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {
 }
 
 // GetTxCmd returns the capability module's root tx command.
@@ -119,7 +119,7 @@ func (am AppModule) Route() sdk.Route {
 func (AppModule) QuerierRoute() string { return types.QuerierRoute }
 
 // LegacyQuerierHandler returns the capability module's Querier.
-func (am AppModule) LegacyQuerierHandler(legacyQuerierCdc *codec.LegacyAmino) sdk.Querier {
+func (am AppModule) LegacyQuerierHandler(_ *codec.LegacyAmino) sdk.Querier {
 	return nil
 }
 

x/qgb/types/codec.go

@@ -5,7 +5,7 @@ import (
 	cdctypes "github.com/cosmos/cosmos-sdk/codec/types"
 )
 
-func RegisterCodec(cdc *codec.LegacyAmino) {
+func RegisterCodec(_ *codec.LegacyAmino) {
 }
 
 func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {