Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to Go 1.20 #1692

Merged
merged 7 commits into from
May 5, 2023
Merged

chore: upgrade to Go 1.20 #1692

merged 7 commits into from
May 5, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 3, 2023

Closes #1691

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label May 3, 2023
@rootulp rootulp requested a review from evan-forbes as a code owner May 3, 2023 14:59
@rootulp rootulp self-assigned this May 3, 2023
@MSevey MSevey requested review from a team and cmwaters and removed request for a team May 3, 2023 14:59
@MSevey MSevey requested a review from a team May 4, 2023 02:05
@rootulp rootulp marked this pull request as draft May 4, 2023 02:07
@rootulp rootulp marked this pull request as ready for review May 4, 2023 02:26
@rootulp rootulp added this to the Mainnet milestone May 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1692 (9a98172) into main (82b22d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   52.82%   52.82%           
=======================================
  Files          97       97           
  Lines        6256     6256           
=======================================
  Hits         3305     3305           
  Misses       2618     2618           
  Partials      333      333

cmwaters
cmwaters previously approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/shares/parse_test.go Outdated Show resolved Hide resolved
@MSevey MSevey requested a review from a team May 4, 2023 15:24
@rootulp rootulp enabled auto-merge (squash) May 4, 2023 15:24
@rootulp rootulp requested a review from cmwaters May 4, 2023 15:24
evan-forbes
evan-forbes approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, didn't approve yesterday cause a bunch of CI was failing due to the github outage. reran CI and its all fine

@rootulp rootulp merged commit 2dc35d9 into celestiaorg:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump to go version 1.20
4 participants
@rootulp @codecov-commenter @cmwaters @evan-forbes