Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli and add cli integration test #171

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jan 4, 2022

Description

This PR updates the cli to the latest refactor first introduced in #129, along with adding an integration test for the cli.

TODO:

  • switch back to the celestia-core branch release/v0.34.x-celestia after #607 is merged
  • maybe only run the integration test with the integration build tag, as it take a while

closes: #132 and #39

@evan-forbes evan-forbes self-assigned this Jan 6, 2022
@evan-forbes evan-forbes marked this pull request as ready for review January 6, 2022 21:45
go.mod Outdated Show resolved Hide resolved
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix WirePayForMessage transaction generation when using cli
3 participants