test: fuzz share commitments #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
previously approved these changes
May 12, 2023
pkg/square/testdata/fuzz/FuzzSquareShareCommitments/dabfc57957837b0a
Outdated
Show resolved
Hide resolved
evan-forbes
approved these changes
May 15, 2023
rootulp
approved these changes
May 15, 2023
pkg/square/builder.go
Outdated
Comment on lines
346
to
348
| func (b *Builder) NumTxs() int { | ||
| return len(b.txs) | ||
| return len(b.txs) + len(b.pfbs) | ||
| } |
There was a problem hiding this comment.
[optional] this function may warrant a clarifying godoc
// NumTxs returns the total number of txs (PFBs + normalTxs)
func (b *Builder) NumTxs() int {
return len(b.txs) + len(b.pfbs)
}we may also consider renaming the field b.txs => b.normalTxs
There was a problem hiding this comment.
I'm not 100% convinced about normal txs. I don't like that normality is defined on the basis of whether there is a PFB or not
There was a problem hiding this comment.
I'm open to other names to help disambiguate. Candidates: nonPFBTxs
| @@ -52,7 +52,7 @@ func FuzzSquare(f *testing.F) { | |||
| builder, err := square.NewBuilder(appconsts.DefaultMaxSquareSize, orderedTxs...) | |||
| require.NoError(t, err) | |||
| totalPfbs := builder.NumPFBs() | |||
| totalNormalTxs := builder.NumTxs() | |||
| totalNormalTxs := builder.NumTxs() - totalPfbs | |||
There was a problem hiding this comment.
[optional] an exported function on the builder for normal txs: builder.NumNormalTxs()
There was a problem hiding this comment.
I think I'll wait for the need to arise first
Codecov Report
@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 51.93% 52.00% +0.06%
==========================================
Files 94 94
Lines 6084 6088 +4
==========================================
+ Hits 3160 3166 +6
+ Misses 2596 2594 -2
Partials 328 328
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1744, closes: #1747