Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify proofs in ADR 11 #1785

Merged
merged 2 commits into from
May 18, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 17, 2023

Closes #1724

@rootulp rootulp added the ADR item is directly relevant to writing or modifying an ADR label May 17, 2023
@rootulp rootulp requested a review from nashqueue May 17, 2023 20:34
@rootulp rootulp self-assigned this May 17, 2023
@rootulp rootulp changed the title docs: clarify proofs docs: clarify proofs in ADR 11 May 17, 2023
@MSevey MSevey requested a review from a team May 17, 2023 20:35
@rootulp rootulp enabled auto-merge (squash) May 17, 2023 20:35
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for @nashqueue

@rootulp
Copy link
Collaborator Author

rootulp commented May 18, 2023

Screenshot 2023-05-18 at 11 58 38 AM

which requirement isn't met for this to auto-merge? @MSevey is there a rule enabled on this repo that forces PRs to be up-to-date with respect to main in order to merge? I would check myself but I don't have permission to see 👀

@rootulp rootulp added this to the Post-mainnet milestone May 18, 2023
@MSevey MSevey requested a review from a team May 18, 2023 16:01
@rootulp rootulp merged commit a16c964 into celestiaorg:main May 18, 2023
@MSevey
Copy link
Member

MSevey commented May 18, 2023

respect

@rootulp must be update to date required. I'll remove that.

@rootulp
Copy link
Collaborator Author

rootulp commented May 18, 2023

Thanks! I expect disabling that rule will help a lot

@rootulp rootulp deleted the rp/adr-11-clarify-proofs branch May 18, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR item is directly relevant to writing or modifying an ADR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADR11 clarification around proofs
4 participants