Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade protobuf #3155

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 5, 2024

Fixes an issue discovered by govulncheck

Vulnerability #1: GO-2024-2611
    Infinite loop in JSON unmarshaling in google.golang.org/protobuf
  More info: https://pkg.go.dev/vuln/GO-2024-2611
  Module: google.golang.org/protobuf
    Found in: google.golang.org/protobuf@v1.32.0
    Fixed in: google.golang.org/protobuf@v1.33.0

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 5, 2024

Blocked on golang/protobuf#1596

@rootulp rootulp changed the title chore(deps): upgrade to protobuf 1.33.0 chore(deps): upgrade protobuf Mar 6, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 6, 2024

govulncheck is still failing because we need to bump to Go 1.22.1 which I'll do in a separate PR.

@rootulp rootulp marked this pull request as ready for review March 6, 2024 14:36
Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Walkthrough

Walkthrough

The update focuses on upgrading dependencies related to Protocol Buffers in a Go project, enhancing compatibility, performance, and security by incorporating the latest improvements and fixes from github.com/golang/protobuf and google.golang.org/protobuf.

Changes

File(s) Change Summary
go.mod, go.sum Updated github.com/golang/protobuf to v1.5.4
Updated google.golang.org/protobuf to v1.33.0
go.work.sum Added github.com/golang/protobuf v1.5.4 module
test/testground/go.mod, Updated various dependencies including
test/testground/go.sum github.com/stretchr/testify, github.com/prometheus/client_model,
github.com/spf13/afero, google.golang.org/grpc,
google.golang.org/protobuf, and added golang.org/x/xerrors

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

staheri14
staheri14 previously approved these changes Mar 6, 2024
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it appears the other PR for updating Go is already submitted, so this one can be merged subsequently.

cmwaters
cmwaters previously approved these changes Mar 7, 2024
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump it in the test ground go mod as well?

evan-forbes
evan-forbes previously approved these changes Mar 7, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 7, 2024

Do we need to bump it in the test ground go mod as well?

I'm not observing any changes when I run:

$ make mod
--> Syncing workspaces
--> Updating go.mod
--> Updating go.mod in ./test/testground
$ gs
On branch rp/bump-protobuf
Your branch is up to date with 'origin/rp/bump-protobuf'.

nothing to commit, working tree clean

since they're indirect deps in testground I guess they don't need to be explicitly bumped 🤷‍♂️

@rootulp rootulp dismissed stale reviews from evan-forbes, cmwaters, and staheri14 via 4ff10f2 March 7, 2024 15:11
@celestia-bot celestia-bot requested review from a team and rach-id and removed request for a team March 7, 2024 15:12
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 7, 2024

oh strange, after I merged in main and re-ran make mod the testground go.mod indirect deps for protobuf were bumped

@rootulp rootulp enabled auto-merge (squash) March 7, 2024 15:13
@rootulp rootulp requested a review from cmwaters March 7, 2024 15:13
@rootulp rootulp merged commit 80968cc into celestiaorg:main Mar 7, 2024
33 checks passed
@rootulp rootulp deleted the rp/bump-protobuf branch March 7, 2024 23:02
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this pull request Apr 2, 2024
Fixes an issue discovered by govulncheck

```
Vulnerability celestiaorg#1: GO-2024-2611
    Infinite loop in JSON unmarshaling in google.golang.org/protobuf
  More info: https://pkg.go.dev/vuln/GO-2024-2611
  Module: google.golang.org/protobuf
    Found in: google.golang.org/protobuf@v1.32.0
    Fixed in: google.golang.org/protobuf@v1.33.0
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants