Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Improvement] Make variable for go version #2698

Closed
MSevey opened this issue Sep 11, 2023 · 0 comments
Closed

[CI Improvement] Make variable for go version #2698

MSevey opened this issue Sep 11, 2023 · 0 comments
Assignees
@ramin
Labels
area:node Node ci:actions

Comments

@MSevey
Copy link
Member

MSevey commented Sep 11, 2023 

          [general question]

Is it possible to make this var? We have it in like 3-5 places in CI and changing it manually all the time is a PITA

Originally posted by @Wondertan in #2661 (comment)
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Sep 11, 2023
@renaynay renaynay added area:node Node ci:actions and removed needs:triage external Issues created by non node team members labels Sep 21, 2023
@ramin ramin self-assigned this Oct 2, 2023
@ramin ramin mentioned this issue Oct 4, 2023
Merged
ramin added a commit that referenced this issue Oct 30, 2023
@ramin
(ci) update github actions ci to use a single GO_VERSION variable (#2806
1552e9e 
)

This sets a single variable (`GO_VERSION`) in the main `ci.yml`
workflow, which will be the single place we set the current go version.
We then run a `setup` job that sets an required output for subsequent
jobs to use, adding:

```
with:
  go-version: ${{ needs.setup.outputs.go-version }}
```

Where we had previously either:

1) duplicated the GO_VERSION env var in that workflow
2) passed in `1.21` or whatever go version explicitly

When the rpc openrpc.json workflow check changes are merged, this will
also prevent another duplication of the go version appearing.

refs #2698
@ramin ramin closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramin ramin

Labels
area:node Node ci:actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramin @MSevey @renaynay