Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Allow clients to configure Gas Price in SubmitOptions #3053

Closed
tuxcanfly opened this issue Dec 23, 2023 · 3 comments · Fixed by #3094
Closed

[Feature Request]: Allow clients to configure Gas Price in SubmitOptions #3053

tuxcanfly opened this issue Dec 23, 2023 · 3 comments · Fixed by #3094
Assignees
@distractedm1nd
Labels
enhancement New feature or request external Issues created by non node team members

Comments

@tuxcanfly
Copy link
Contributor

Implementation ideas

Currently, clients are able to configure Fee and Gas as part of SubmitOptions. As Gas depends on blob size, it requires the client to calculate it for each blob and adjust Fee accordingly. The client only cares about the Gas Price so that the transaction can be prioritised.

Hence this is a feature request that the client should be able to configure a Gas Price once that can be used to calculate and adjust fee for all subsequent submitted blobs.
@tuxcanfly tuxcanfly added the enhancement New feature or request label Dec 23, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Dec 23, 2023
@musalbas
Copy link
Member

musalbas commented Jan 4, 2024

I think it would be cleaner to also add it as a parameter for transactions being submitted, rather than as global variable. Or rather, the global variable could just be to set the default.

@tuxcanfly
Copy link
Contributor Author

tuxcanfly commented Jan 10, 2024 •
edited
Loading

Partially addressed by rollkit/go-da#30 as we're handling this in celestia-da for now.

@adlerjohn
Copy link
Member

+1 to it should be a per-tx parameter.

@distractedm1nd distractedm1nd self-assigned this Jan 11, 2024
@distractedm1nd distractedm1nd mentioned this issue Jan 11, 2024
Merged
distractedm1nd added a commit that referenced this issue Jan 23, 2024
@distractedm1nd
refactor(blob)!: replace SubmitOptions with a GasPrice parameter (#3094)
debad37 
This PR modifies the blob interface to replace SubmitOptions with
GasLimit. The reasoning here is that setting a gas price is a lot more
intuitive/easier than calculating the fee and gas limit, which take
cosmossdk and celestia-app imports to calculate without much effort.
Related: rollkit/go-da#30

Based on a suggestion from @vgonkivs we alias float64 to be able to
provide a default value, but now that its there I think we can just have
float64 and the same constructor, as it doesn't change that much.

Breaks the API, cc @jcstein, @tuxcanfly, and @Ferret-san .

Closes #3053.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
enhancement New feature or request external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(blob)!: replace SubmitOptions with a GasPrice parameter celestiaorg/celestia-node
4 participants
@tuxcanfly @adlerjohn @musalbas @distractedm1nd