[WIP]feat(shwap): add RangeNamespaceDataID along with the RangeNamespaceData #3709
Conversation
vgonkivs
force-pushed
the
implement_range_container
branch
from
c708e7e
to
9aebbdf
Compare
vgonkivs
force-pushed
the
implement_range_container
branch
from
d5c6f0f
to
8905eb9
Compare
| namespacedShares := make([]share.Share, count) | ||
| copy(namespacedShares, shares[from:from+count]) | ||
|
|
| // Proofs iterates over each row and collects proofs. | ||
| func (nd NamespaceData) Proofs() []*nmt.Proof { |
There was a problem hiding this comment.
nit: move closer to Flatten above
| if endIndex > uint16(edsSize) { | ||
| return errors.New("RangeNamespaceDataID: end index exceeds ODS length") | ||
| } | ||
| return nil |
| return RangeNamespaceDataID{}, fmt.Errorf("converting SampleId from binary: %w", err) | ||
| } | ||
|
|
||
| return RangeNamespaceDataID{ |
| root.RowRoots[rowStart+i], | ||
| ) | ||
| if !verified { | ||
| return fmt.Errorf("RangeNamespaceData: proof verification failed at row: %d", rowStart+i) |
There was a problem hiding this comment.
Should wrap ErrVerificationFailed
| // Length is a number of shares to of the requested range. | ||
| Length uint16 |
There was a problem hiding this comment.
In other shwap types we use int in ID struct and convert to the wire type in marshal functions
There was a problem hiding this comment.
Also, do you think uint16 is enough? Why not uint32?
There was a problem hiding this comment.
I think uint32 is better. Thanks.
| func RangedNamespaceDataFromShares( | ||
| rawShares [][]share.Share, | ||
| namespace share.Namespace, | ||
| rowIndex, from, to int, | ||
| ) (NamespaceData, error) { |
There was a problem hiding this comment.
Why not make it return RangeNamespaceData? To avoid handling proofs only in it?
We need to additionally check the |
No description provided.