service/state: Provide simple scaffold for `StateService` and implement `CoreAccess` #420

renaynay · 2022-02-09T16:38:08Z

This PR is the first implementation of StateAccessor over core: CoreAccess. It will provide a light node with the ability to be initialised with a connection to a celestia-core endpoint over which it can query for account balances and submit transactions.

ADR for reference.

Two notes:

Although it was documented in the ADR, I decided against using the lens dependency as it is still in development and introduced a bit more overhead / complexity than was necessary for two simple queries against the application.
It is extremely difficult to write unit tests that test the full functionality of CoreAccess as we lack a good way to mock the celestia-app for testing purposes. This will be discussed in the following week and will hopefully provide more clarity in how we can increase test coverage for this feature.

TODO:

adlerjohn

Lint error

node/services/config.go

liamsi

Although it was documented in the ADR, I decided against using the lens dependency as it is still in development and introduced a bit more overhead / complexity than was necessary for two simple queries against the application

~~Do you mind quickly updating the ADR accordingly in this PR?~~ I've missed the updated ADR 🙈

service/state/doc.go

liamsi

👏🏼

node/state/core.go

service/state/core_access.go

adlerjohn

Merge conflicts

renaynay · 2022-02-25T14:01:43Z

Rebased.

renaynay · 2022-02-25T14:09:52Z

FYI the test is currently broken as mock celestia-app isn't working.

adlerjohn

Lint errors!

service/state/core_access.go

renaynay · 2022-03-01T16:28:05Z

Test is failing due to failure in mock celestia-app

adlerjohn

Is CI expected to fail, or no?

renaynay · 2022-03-03T12:33:33Z

Yes @adlerjohn

adlerjohn

utACK

Wondertan

Mostly looks good and straightforward. Good that the implementation turned out to be quite small even without lens.

Only a few things that require changes, other than that are mostly nits, questions, and discussions on how things should look further.

Also, part of the review process resulted into #415 (comment)

docs/adr/adr-004-state-interaction.md

service/state/interface.go

service/state/core_access.go

go.mod

service/state/core_access.go

node/components.go

node/state/core.go

service/state/core_access.go

node/services/config.go

…ault

… state access available on full node too

…bmission

…erface for now

…implement Path method in Keystore | lint

…tead of types.AccAddress

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>

…elestiaorg#570

evan-forbes mentioned this pull request Feb 10, 2022

Refactor to export testutils celestiaorg/celestia-app#207

Merged

renaynay force-pushed the state-scaffold-without-lens branch from 6957cf0 to 64407bf Compare February 11, 2022 21:21

renaynay marked this pull request as ready for review February 11, 2022 21:33

renaynay requested review from liamsi and Wondertan as code owners February 11, 2022 21:33

renaynay changed the title ~~[ DRAFT ] service/state: Provide simple scaffold for StateService and implement CoreAccess~~ service/state: Provide simple scaffold for StateService and implement CoreAccess Feb 11, 2022

renaynay added the area:state Related to fetching state and state execution label Feb 11, 2022

adlerjohn reviewed Feb 12, 2022

View reviewed changes

node/services/config.go Outdated Show resolved Hide resolved

renaynay requested a review from adlerjohn February 13, 2022 14:42

renaynay force-pushed the state-scaffold-without-lens branch from c657f0e to 1bd89f1 Compare February 15, 2022 11:24

liamsi reviewed Feb 17, 2022

View reviewed changes

service/state/doc.go Show resolved Hide resolved

liamsi approved these changes Feb 17, 2022

View reviewed changes

node/state/core.go Outdated Show resolved Hide resolved

vgonkivs reviewed Feb 22, 2022

View reviewed changes

service/state/core_access.go Outdated Show resolved Hide resolved

adlerjohn reviewed Feb 23, 2022

View reviewed changes

renaynay force-pushed the state-scaffold-without-lens branch from 2952cbf to b459ca3 Compare February 25, 2022 14:01

renaynay mentioned this pull request Feb 25, 2022

[Feature Request]: Keys Management #415

Closed

renaynay requested review from adlerjohn and vgonkivs February 28, 2022 09:40

adlerjohn reviewed Mar 1, 2022

View reviewed changes

service/state/core_access.go Outdated Show resolved Hide resolved

service/state/core_access.go Outdated Show resolved Hide resolved

service/state/core_access.go Show resolved Hide resolved

renaynay requested review from liamsi and adlerjohn March 1, 2022 16:12

adlerjohn reviewed Mar 2, 2022

View reviewed changes

adlerjohn approved these changes Mar 4, 2022

View reviewed changes

Wondertan requested changes Mar 4, 2022

View reviewed changes

renaynay and others added 23 commits March 30, 2022 13:14

test: failing due to cel-app panic with InitChain

615d018

chore|refactor: go mod tidy & change grpc dial to DialContext

d8d27fa

fix: add watchdog dep

be0add8

chore: lint

07e7ae4

refactor: dont return err with constructor

54be1dd

docs: update state ADR to remove mentions of lens

2065fc3

fix: remove unused encCfg field from CoreAccess

cf976ac

refactor: remove KeyConfig and use "default" as KeyringAccName by def…

2ebf8ce

…ault

chore: mod tidy

acea07c

refactor: setup queryClient in Start of CoreAccess

e35079f

docs: fix typo in lightComponents doc

edaa05f

comment out test

a6ff606

chore: lint

8149dfe

bug: grpc needs insecure credentials

5b8334f

refactor: BalanceForAddress takes types.AccAddress instead of string,…

1904ecb

… state access available on full node too

refactor: use BroadcastMode_BROADCAST_MODE_BLOCK as default for tx su…

c704661

…bmission

feat: add SubmitTxWithBroadcastMode but dont add to StateAccessor int…

c73a978

…erface for now

refactor: pass keystore to constructor instead of string to path and …

9a9b18c

…implement Path method in Keystore | lint

chore: update celestia-core dep to prevent weird lint error

97148ea

refactor: add state serv to baseComponents

a68e0a9

refactor: BalanceForAddress takes a types.Address from cosmos sdk ins…

3741929

…tead of types.AccAddress

doc: fix typo

3858b80

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>

test: delete unit test for core access as it doesnt work in favour of c…

db90c98

…elestiaorg#570

renaynay force-pushed the state-scaffold-without-lens branch from 3fa7e5e to db90c98 Compare March 30, 2022 12:16

refactor: add params.Network after rebase

2fa5545

renaynay merged commit a6a50b0 into celestiaorg:main Mar 30, 2022

renaynay deleted the state-scaffold-without-lens branch March 30, 2022 16:04

liamsi mentioned this pull request Apr 11, 2022

Use tagged releases for Celestia dependencies #606

Closed

This was referenced Apr 26, 2022

state: Implement ability to request account balance info from Celestia Core node #27

Closed

rpc: Implement an RPC endpoint for users to submit transactions to Celestia Node #28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

service/state: Provide simple scaffold for `StateService` and implement `CoreAccess` #420

service/state: Provide simple scaffold for `StateService` and implement `CoreAccess` #420

renaynay commented Feb 9, 2022 •

edited

Loading

adlerjohn left a comment

liamsi left a comment •

edited

Loading

liamsi left a comment

adlerjohn left a comment

renaynay commented Feb 25, 2022

renaynay commented Feb 25, 2022

adlerjohn left a comment

renaynay commented Mar 1, 2022

adlerjohn left a comment

renaynay commented Mar 3, 2022

adlerjohn left a comment

Wondertan left a comment •

edited

Loading

service/state: Provide simple scaffold for StateService and implement CoreAccess #420

service/state: Provide simple scaffold for StateService and implement CoreAccess #420

Conversation

renaynay commented Feb 9, 2022 • edited Loading

adlerjohn left a comment

Choose a reason for hiding this comment

liamsi left a comment • edited Loading

Choose a reason for hiding this comment

liamsi left a comment

Choose a reason for hiding this comment

adlerjohn left a comment

Choose a reason for hiding this comment

renaynay commented Feb 25, 2022

renaynay commented Feb 25, 2022

adlerjohn left a comment

Choose a reason for hiding this comment

renaynay commented Mar 1, 2022

adlerjohn left a comment

Choose a reason for hiding this comment

renaynay commented Mar 3, 2022

adlerjohn left a comment

Choose a reason for hiding this comment

Wondertan left a comment • edited Loading

Choose a reason for hiding this comment

service/state: Provide simple scaffold for `StateService` and implement `CoreAccess` #420

service/state: Provide simple scaffold for `StateService` and implement `CoreAccess` #420

renaynay commented Feb 9, 2022 •

edited

Loading

liamsi left a comment •

edited

Loading

Wondertan left a comment •

edited

Loading