Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant compositions + fix local:docker ones #172

Merged
merged 5 commits into from
Feb 16, 2023
Merged

chore: remove redundant compositions + fix local:docker ones #172

merged 5 commits into from
Feb 16, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Feb 10, 2023 •
edited
Loading

Overview

Closes #171

In addition, I removed the 32 sq sz to prepare for 128 or 256 instead

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 added test Request for creating a test-case testground related to testground labels Feb 10, 2023
@Bidon15 Bidon15 self-assigned this Feb 10, 2023
@Bidon15 Bidon15 mentioned this pull request Feb 16, 2023
Open
tty47
tty47 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the file names, LGTM 🚀
great job!

@Bidon15 Bidon15 merged commit f4d1fd1 into celestiaorg:main Feb 16, 2023
@Bidon15 Bidon15 deleted the fix-seeds branch February 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 approved these changes

@derrandz derrandz Awaiting requested review from derrandz

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@smuu smuu Awaiting requested review from smuu

@sysrex sysrex Awaiting requested review from sysrex

Assignees

@Bidon15 Bidon15

Labels
test Request for creating a test-case testground related to testground
Projects
Celestia DevOps/Testing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running the example in the readme fails
2 participants
@Bidon15 @tty47