Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set poll options on token fetcher. #414

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

rkachowski
Copy link

@rkachowski rkachowski commented Sep 29, 2021

Description

Sets a poll config on the token fetcher to periodically stream uncataloged tokens from the database for reindexing. This is similar to how the internal transaction fetcher retrieves a list of unprocessed blocks to fetch transactions for.

Tested

  • Deployed to staging and changed some token values
    • Set name and symbol to placeholder values and cataloged to false
    • After 60 seconds they were reindexed with the previous (correct) values

Issues

  • Relates to celo-org/data-services#46

Checklist

  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I added code comments for anything non trivial.
  • I added documentation for my changes.
  • If I added/changed/removed ENV var, I submitted a PR to https://github.com/celo-org/monorepo to update the list and default values of env vars.
  • If I add new indices into DB, I checked, that they are not redundant with PGHero or other tools.

@github-actions
Copy link

github-actions bot commented Sep 29, 2021

Unit Test Results

       3 files  ±0     222 suites  ±0   3m 9s ⏱️ ±0s
2 048 tests ±0  2 003 ✔️ ±0  45 💤 ±0  0 ±0 

Results for commit 6e233ee. ± Comparison against base commit 6e233ee.

♻️ This comment has been updated with latest results.

Copy link

@carterqw2 carterqw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@rkachowski rkachowski merged commit 6e233ee into master Sep 29, 2021
@rkachowski rkachowski deleted the feature/poll_token_fetcher branch September 29, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants