Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactor: Decoupling pool-registry from pool-system and pool-fees #1983

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm commented Aug 23, 2024

Description

The intention of this PR is to clean the mess we currently have when testing/benchmarking pool things from pool-registry PoV. Almost no production logic is touched, only for cases that affect the benchmarking

NOTE: Current tests do not cover everything, but they cover what the same they covered before the refactor.

Changes and Descriptions

  • Remove all pool-related dependencies from pool-registry (look at the mock.rs file!)
  • Added BoundedVec when needed to carry the Max information associated to those vecs
  • Remove PoolMetadata trait which is not used.
  • Simplify weight computation by removing some unused extra params.
  • Based of this comment I removed the capability of update & execute in the same call, which is impossible to be used right now in the runtime, and in case of required, it can be batched. Tell me if you agree or I revert.
  • Reorganize benchmarking traits (WIP)
  • Other minor simplifications

Still WIP

  • Correct reorganization of benchmark traits/methods
  • Fix execute_update benchmark

@lemunozm lemunozm added the I6-refactoring Code needs refactoring. label Aug 23, 2024
@lemunozm lemunozm self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I6-refactoring Code needs refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant