fix: Backward compatible type subscriptions/unions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the codebase specified support for Python>=3.8, when it used `|` type union syntax (introduced in 3.10), and subscriptable built-in types (introduced in 3.9). This change uses earlier syntax in order to allow 3.8 interpreters to handle type specific code. Signed-off-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: Sam Lock <sam@swlock.co.uk>
Sambigeara
force-pushed
the
fix/type-union-backwards-compatibility
branch
from
d47de13
to
935c353
Compare
charithe
approved these changes
Jan 24, 2024
Sambigeara
added a commit
to cerbos/query-plan-adapters
that referenced
this pull request
Jan 25, 2024
Makes type hinting syntax compatible with Python 3.8 (as per the versioning specified in `pyproject.toml`). See cerbos/cerbos-sdk-python#48 for more context. --------- Signed-off-by: Sam Lock <sam@swlock.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the codebase specified support for Python>=3.8, when it used
|type union syntax (introduced in 3.10), and subscriptable built-in types (introduced in 3.9).This change uses earlier syntax in order to allow 3.8 interpreters to handle type specific code.