Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemas: validate correctness of configurations #2215

Closed
3 tasks done
pamfilos opened this issue May 11, 2021 · 0 comments
Closed
3 tasks done

schemas: validate correctness of configurations #2215

pamfilos opened this issue May 11, 2021 · 0 comments
Assignees
@Lilykos

Comments

@pamfilos
Copy link
Collaborator

pamfilos commented May 11, 2021 •
edited by Lilykos
Loading

Now that we accept configurations (config column) for each schema, we should validate the correctness of it

We should:

  • create JSON-schema to validate against
  • add the mechanism to validate the "payload" of configuration on schema creation, update
  • raise exception and handle from cli scripts
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue May 31, 2021
@Lilykos
schemas: add config fixture, update serializer
b193904 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jun 2, 2021
@Lilykos
schemas: add config fixture, update serializer
8cc4500 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jun 2, 2021
@Lilykos
schemas: add config fixture, update serializer
c8a6b50 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jun 15, 2021
@Lilykos
schemas: add config fixture, update serializer
ef9fcd3 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jul 2, 2021
@Lilykos
schemas: add config fixture, update serializer
25b1297 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jul 2, 2021
@Lilykos
schemas: add config fixture, update serializer
1acc0a5 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
pamfilos pushed a commit to pamfilos/analysis-preservation.cern.ch that referenced this issue Oct 12, 2021
@Lilykos @pamfilos
schemas: add config fixture, update serializer
7611de2 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
pamfilos pushed a commit to pamfilos/analysis-preservation.cern.ch that referenced this issue Oct 12, 2021
@Lilykos @pamfilos
schemas: add config fixture, update serializer
f92ec94 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
pamfilos pushed a commit to pamfilos/analysis-preservation.cern.ch that referenced this issue Jan 11, 2023
@Lilykos @pamfilos
schemas: add config fixture, update serializer
aca99ce 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
pamfilos pushed a commit to pamfilos/analysis-preservation.cern.ch that referenced this issue Jan 18, 2023
@Lilykos @pamfilos
schemas: add config fixture, update serializer
06a76b0 
* closes cernanalysispreservation#2215

Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
pamfilos pushed a commit to pamfilos/analysis-preservation.cern.ch that referenced this issue Jan 30, 2023
@Lilykos @pamfilos
schemas: add notifications config in schemas
06994cf 
* adds notification config in questionnaires
* updates mail/users.py with new functions and tests
* adds functions for checking config conditions
* fix typo

* adds `custom` folder in mail, for notifications
* adds functions for subject/message/recipients
* adds unit tests
* updates schema configs with the new functions

* uses new procedure that makes use of schema configs
* updates schema configs
* adds documentation and docstrings
* tests for mails

* closes cernanalysispreservation#2215

* validate config on schema create/update

Signed-off-by: pamfilos <pamfilosf@gmail.com>
Co-authored-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
pamfilos pushed a commit to pamfilos/analysis-preservation.cern.ch that referenced this issue Jan 30, 2023
@Lilykos @pamfilos
schemas: add notifications config in schemas
13f1eb1 
* adds notification config in questionnaires
* updates mail/users.py with new functions and tests
* adds functions for checking config conditions
* fix typo

* adds `custom` folder in mail, for notifications
* adds functions for subject/message/recipients
* adds unit tests
* updates schema configs with the new functions

* uses new procedure that makes use of schema configs
* updates schema configs
* adds documentation and docstrings
* tests for mails

* closes cernanalysispreservation#2215

* validate config on schema create/update

Signed-off-by: pamfilos <pamfilosf@gmail.com>
Co-authored-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilykos Lilykos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lilykos @pamfilos