-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove namespace field from scaleTargetRef for hpa #271
base: main
Are you sure you want to change the base?
Conversation
@fivesheep - Thank you for the pull request, we will review it soon. Can you please confirm that when you removed the line locally, HPA worked for you? |
@divyansh-gupta yes, it works after deleting that line. however, the version of the hpa we have is a bit old. I am getting this error
i can update this from the same pr to upgrade this to autoscaling/v2 |
That'd be great if you wouldn't mind adding that. Thanks! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fivesheep The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bmsiegel the pr has been updated and tested |
test failure seems to be unrelated, the command from the test as shown below, didn't even trigger the hpa logic, which is off by default
|
Yea I agree, I merged a fix to this recently (ccf4d25). Would you mind rebasing? |
Signed-off-by: Xiayang Wu <xwu@rippling.com>
Signed-off-by: Xiayang Wu <xwu@rippling.com>
Thanks, running testing now |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Trying to enable hpa with this chart and getting the following error
per
HorizontalPodAutoscaler
spec, it doesn't have this namespace field fromscaleTargetRef
, removing this line shall fix it. more example can be found from https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/#autoscaling-on-multiple-metrics-and-custom-metrics