Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing a descriptor for Zenodo's DOI #443

Merged
merged 27 commits into from
May 15, 2024

Conversation

castelao
Copy link
Member

@castelao castelao commented Aug 1, 2023

See issue #127 for discussion of these changes.

Release checklist

  • Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

Comments

@ethanrd and @davidhassell, since this came up in the last meeting, let's try it again? Just checking, as I recall the decision (from the governance panel long time ago) was to use Zenodo integrated with GitHub to make the recording and update process easier. If so, let's use a .zenodo.json descriptor to avoid manual editing in the future. Just a reminder, with that choice, we might not be able to edit all fields.

Note: This is just a skeleton just to guide it. It is missing fields, and records. For instance, who is going on the list of creators? I guess the natural choice would be the list of authors in the document.

EDIT 2023-11-8: Added issue number

@ethanrd
Copy link
Member

ethanrd commented Aug 1, 2023

Hi Gui @castelao - Thanks for getting this started!
Here's the comment on issue #127 that summarizes the CF Governance Panel's discussion/decision on DOIs.

@castelao castelao marked this pull request as ready for review November 22, 2023 16:33
@castelao
Copy link
Member Author

@ethanrd it's open for review. Note that it is missing several affiliations and ORCIDs.

.zenodo.json Outdated Show resolved Hide resolved
@castelao
Copy link
Member Author

@larsbarring , I'm sorry. I let my branch fall behind, creating that confusion in your PR. To keep it simple, I rebased my branch and added manually your changes. Could you double check if I did it correctly? Thanks!

@larsbarring
Copy link
Contributor

Looks good as far as I can see. Many thanks. As the change/addition in this PR is focussed and does not involve any other file/components of the repo it is a "clean" addition even if it fell behind the main branch. It just looked more complex than it actually was.

.zenodo.json Outdated Show resolved Hide resolved
.zenodo.json Outdated Show resolved Hide resolved
@JonathanGregory JonathanGregory linked an issue Jan 1, 2024 that may be closed by this pull request
@JonathanGregory JonathanGregory added this to the 1.12 milestone Jan 1, 2024
Copy link
Member

@ethanrd ethanrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the one comment on the description text.

.zenodo.json Outdated Show resolved Hide resolved
castelao and others added 6 commits February 2, 2024 09:59
I used the authors list from version v1.10. I don't know affiliations or
ORCIDs, but it's better anyways each one to add yours.
As discussed in the meeting today.
My branch was behind with the official main creating some confusion with
@larsbarring's PR. I rebased my branch, and I'm adding here his changes.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
@JonathanGregory
Copy link
Contributor

I suppose I should have put this here.

Dear Gui

Thanks for working on this. I commented on this PR in the associated issue. Please could you look at that? In particular, I think that David's suggestion, while reasonable, should not be made in this PR, because (if I understand correctly) the text you have used is the abstract of the conventions document.

Jonathan

@JonathanGregory
Copy link
Contributor

The reason for my commenting in the issue, rather than in the PR, is because that's generally preferred for CF discussions on substantive questions (as distinct from typos or other things that don't change the content or meaning significantly). That keeps the discussion all in one place, for easy reference and to make it more obvious to the whole community.

@castelao
Copy link
Member Author

castelao commented Feb 2, 2024

@JonathanGregory , I'm sorry for my lack of attention on #127.

Just checking. Shall I revert 7a458440?

@JonathanGregory
Copy link
Contributor

Just checking. Shall I revert 7a458440?

I'm not sure, I'm sorry to say! Am I right that you copied the text initially from the abstract of the conventions? If so, I think that was a good choice, and my opinion is that it would be best, at the moment, to use that text, after deleting the two "[...]" link texts, the "\n", and the "Descriptive information:" at the start. I think those were the editorial changes suggested by Ethan and David. David also suggested changing the content. As I wrote in #127, I feel it would be better to do that in a separate issue, and change it in the abstract as well, to keep them consistent. OK?

Many thanks again for your work on this.

@castelao
Copy link
Member Author

castelao commented Feb 9, 2024

@ethanrd and @JonathanGregory , I think I covered all the requests. Please let me know if it is missing anything.

@JonathanGregory
Copy link
Contributor

Dear Gui @castelao

Thanks for the updates. The text looks fine to me, except that Ethan suggested omitting "Descriptive information" at the start. Also, please see #127 about the list of contributors.

Best wishes

Jonathan

Copy link
Member

@ethanrd ethanrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes: remove "Descriptive information" from start of abstract text; add my ORCID.

.zenodo.json Outdated Show resolved Hide resolved
.zenodo.json Outdated Show resolved Hide resolved
.zenodo.json Outdated Show resolved Hide resolved
@japamment, could you double check it, please?
@erget
Copy link
Member

erget commented Feb 20, 2024

@castelao here's my pitiful, unused ORCID: 0000-0002-1041-232X

.zenodo.json Outdated Show resolved Hide resolved
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
@castelao
Copy link
Member Author

Hi everyone. Is this ready to move forward? It is still missing a few ORCIDs, but we can always add them later.

@JonathanGregory
Copy link
Contributor

Yes, I think it's ready. It would be great to close this ancient issue (#127)! Shall I merge this PR?

@JonathanGregory JonathanGregory linked an issue Apr 29, 2024 that may be closed by this pull request
@davidhassell
Copy link
Contributor

Thanks, everyone, for your working on this :)

@HeinkeH, please double check it.
@JonathanGregory JonathanGregory merged commit 87403be into cf-convention:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect ORCID IDs for authors DOIs for CF Convention releases?