-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
…ed on user feedback.
5167374
to
7ff4073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've been testing in a browser with CORS disabled. And in my mind the CORS issue would somehow be solved once the app was deployed but now I'm realizing that this will never be requesting from the same origin since it's a call to S3. I've also tried We'd need to enable HEAD CORS requests on the S3 bucket: S3 Doc |
There are also a ton of calls to the Filing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the additional changes, going to merge this in and the CORS stuff can be tracked elsewhere
Closes #138
Closes cfpb/hmda-frontend#602
Changes
Testing
cypress.env.json
fileyarn cypress run
Screenshots