Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Note History #143

Merged
merged 8 commits into from
Aug 27, 2020
Merged

Note History #143

merged 8 commits into from
Aug 27, 2020

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Aug 19, 2020

Closes cfpb/hmda-frontend#603

Displays the edit history of an Institution.

This is safe to review and merge. Once the backend bugs are addressed we can validate and deploy.

Pending:

@meissadia meissadia marked this pull request as ready for review August 25, 2020 16:19
@meissadia meissadia requested a review from wpears August 25, 2020 16:20
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just have one comment on the parseInt.

I'd say it'd probably be wise to write tests for /NoteHistory/utils.js` since there's a decent amount of touchy logic neatly encapsulated there, so tests should be easy to write and fairly high-mileage.

src/institution/NoteHistory/utils.js Outdated Show resolved Hide resolved
@meissadia meissadia requested a review from wpears August 27, 2020 20:47
@meissadia
Copy link
Contributor Author

@wpears Added unit tests and fixed a few bugs in the process. Good call 👍🏽

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wpears wpears merged commit 6eee49d into master Aug 27, 2020
@wpears wpears deleted the 603-notes-history branch August 27, 2020 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HMDA Help] Implement Notes History
2 participants