-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protractor tests : using $interval instead of $timeout for notify duration management #41
Comments
👍 We are running into the same issue, and using $interval would solve a big headache for us. |
I have made a fork that changes to $interval here: https://github.com/peakon/angular-notify |
Coud that be used in the main branch ? Otherwise we will have to implement our own... |
@holm thanks for your fork, it works for me 👍 |
soul-wish
added a commit
to soul-wish/angular-notify
that referenced
this issue
May 19, 2017
…th Protractor fix cgross#41 issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I use this module in my application, and I started to write e2e tests with protractor.
There is no problem when writing tests for function using notification which stay on screen, but notification with duration attribute are not testable. This issue comes from the $timeout service to manage notification duration : protractor waits for $timeouts (and $http) before to run actions and expectation. So notification with duration can't be tested as they disappears before protractor tests them.
In documentation (https://github.com/angular/protractor/blob/master/docs/timeouts.md), protractor team precognise to replace $timeout services by $interval services to this kind of issue.
Can you try that to allow protractor testing of notifications with duration ?
The text was updated successfully, but these errors were encountered: