Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to a package #151

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Move to a package #151

merged 7 commits into from
Apr 24, 2024

Conversation

qubixes
Copy link
Collaborator

@qubixes qubixes commented Apr 24, 2024

I think this already works. I tried pip install . + ibridges-gui in another folder and even the icons seem to be there (not sure how though!).

@qubixes qubixes requested a review from chStaiger April 24, 2024 08:09
@chStaiger chStaiger changed the base branch from main to develop April 24, 2024 09:39
chStaiger
chStaiger approved these changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@chStaiger chStaiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!!!
I tested the installation of the package on Windows and Mac and I updated the README.

@chStaiger chStaiger merged commit 236e390 into develop Apr 24, 2024
@chStaiger chStaiger deleted the packaging2 branch April 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chStaiger chStaiger chStaiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qubixes @chStaiger