-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…s match web reality and spec language Merge pull request #4067 from xiaoyinl:parse_own_toString Ref #4178 [Sec 20.3.3.2](https://tc39.github.io/ecma262/#sec-date.parse) requires `Date.parse` should be able to parse the values returned by `Date.toString()`, `Date.toUTCString()` and `Date.toISOString()` in each engine's own implementation. In ChakraCore, if the year is <100, `toString()` and `toUTCString()` don't pad the year to 4 digits, and thus `Date.parse` can't parse them. This PR makes two changes: 1. If the absolute value of the year is less than 1000, pad it to 4 digits 2. For a BC year, output negative year, rather than positive year + "B.C."
- Loading branch information
Showing
6 changed files
with
133 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| //------------------------------------------------------------------------------------------------------- | ||
| // Copyright (C) Microsoft. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information. | ||
| //------------------------------------------------------------------------------------------------------- | ||
|
|
||
| // For dates whose years are less than 1000, Date.toString() and Date.toUTCString() should pad the years | ||
| // to 4 digits. | ||
| // See https://github.com/Microsoft/ChakraCore/pull/4067 | ||
|
|
||
| /// <reference path="../UnitTestFramework/UnitTestFramework.js" /> | ||
| if (this.WScript && this.WScript.LoadScriptFile) { // Check for running in ch | ||
| this.WScript.LoadScriptFile("..\\UnitTestFramework\\UnitTestFramework.js"); | ||
| } | ||
|
|
||
| function testDate(DateObj, toStringExpected, toUTCStringExpected) { | ||
| assert.areEqual(toStringExpected, DateObj.toString(), "Date.toString() returns invalid value."); | ||
| assert.areEqual(toUTCStringExpected, DateObj.toUTCString(), "Date.toUTCString() returns invalid value."); | ||
| } | ||
|
|
||
| let tests = [{ | ||
| name: "test if Date.toString() and Date.toUTCString() pad positive years to four digits", | ||
| body: function () { | ||
| testDate(new Date("0001-10-13T05:16:33Z"), "Fri Oct 12 0001 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Sat, 13 Oct 0001 05:16:33 GMT"); | ||
| testDate(new Date("0011-10-13T05:16:33Z"), "Wed Oct 12 0011 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Thu, 13 Oct 0011 05:16:33 GMT"); | ||
| testDate(new Date("0111-10-13T05:16:33Z"), "Mon Oct 12 0111 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Tue, 13 Oct 0111 05:16:33 GMT"); | ||
| testDate(new Date("1111-10-13T05:16:33Z"), "Thu Oct 12 1111 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Fri, 13 Oct 1111 05:16:33 GMT"); | ||
| } | ||
| }, | ||
| { | ||
| name: "test if Date.toString() and Date.toUTCString() pad negative years to four digits", | ||
| body: function () { | ||
| testDate(new Date("-000001-10-13T05:16:33Z"), "Tue Oct 12 -0001 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Wed, 13 Oct -0001 05:16:33 GMT"); | ||
| testDate(new Date("-000011-10-13T05:16:33Z"), "Thu Oct 12 -0011 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Fri, 13 Oct -0011 05:16:33 GMT"); | ||
| testDate(new Date("-000111-10-13T05:16:33Z"), "Sat Oct 12 -0111 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Sun, 13 Oct -0111 05:16:33 GMT"); | ||
| testDate(new Date("-001111-10-13T05:16:33Z"), "Wed Oct 12 -1111 22:16:33 GMT-0700 (Pacific Daylight Time)", | ||
| "Thu, 13 Oct -1111 05:16:33 GMT"); | ||
| } | ||
| }]; | ||
|
|
||
| testRunner.run(tests, { verbose: WScript.Arguments[0] != "summary" }); |